All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Po-Wen Kao <powen.kao@mediatek.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com,
	stanley.chu@mediatek.com, alice.chao@mediatek.com,
	chun-hung.wu@mediatek.com, cc.chou@mediatek.com,
	chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
	yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
Date: Wed, 13 Apr 2022 23:29:53 +0200	[thread overview]
Message-ID: <dcd403b025eb28186c3f05d682c383cb06e5b8ee.camel@gmail.com> (raw)
In-Reply-To: <20220412073131.10644-1-powen.kao@mediatek.com>

Hi, Po wen and Peter


I must give this patch Ack, because:

1. “fHPBReset Flag” can be sent in both host control mode and device
control mode. “buffer id=3 HpbWriteBuffer” can only be sent in device
control mode.

2. “fHPBReset Flag” inactivate all the regions for the whole device.
“buffer id=3 HpbWriteBuffer” can only inactivate all the regions for
this LUN. The LUN is written in the UPIU header.

In the ufshpb_init, we have set fHPBReset Flag. here doesn't need to
issue “buffer id=3 HpbWriteBuffer” in the case of device mode.

Regarding the reset flow issue we are talking about, I will submit a
fix.


Acked-by: Bean Huo <beanhuo@micron.com>


Bean



WARNING: multiple messages have this Message-ID (diff)
From: Bean Huo <huobean@gmail.com>
To: Po-Wen Kao <powen.kao@mediatek.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	 Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com,
	 stanley.chu@mediatek.com, alice.chao@mediatek.com,
	chun-hung.wu@mediatek.com,  cc.chou@mediatek.com,
	chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
	 yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
Date: Wed, 13 Apr 2022 23:29:53 +0200	[thread overview]
Message-ID: <dcd403b025eb28186c3f05d682c383cb06e5b8ee.camel@gmail.com> (raw)
In-Reply-To: <20220412073131.10644-1-powen.kao@mediatek.com>

Hi, Po wen and Peter


I must give this patch Ack, because:

1. “fHPBReset Flag” can be sent in both host control mode and device
control mode. “buffer id=3 HpbWriteBuffer” can only be sent in device
control mode.

2. “fHPBReset Flag” inactivate all the regions for the whole device.
“buffer id=3 HpbWriteBuffer” can only inactivate all the regions for
this LUN. The LUN is written in the UPIU header.

In the ufshpb_init, we have set fHPBReset Flag. here doesn't need to
issue “buffer id=3 HpbWriteBuffer” in the case of device mode.

Regarding the reset flow issue we are talking about, I will submit a
fix.


Acked-by: Bean Huo <beanhuo@micron.com>


Bean



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Bean Huo <huobean@gmail.com>
To: Po-Wen Kao <powen.kao@mediatek.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	 Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com,
	 stanley.chu@mediatek.com, alice.chao@mediatek.com,
	chun-hung.wu@mediatek.com,  cc.chou@mediatek.com,
	chaotian.jing@mediatek.com, jiajie.hao@mediatek.com,
	 yohan.joung@sk.com, jason.li@sk.com, linux-scsi@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/1] scsi: ufs: remove redundant HPB unmap
Date: Wed, 13 Apr 2022 23:29:53 +0200	[thread overview]
Message-ID: <dcd403b025eb28186c3f05d682c383cb06e5b8ee.camel@gmail.com> (raw)
In-Reply-To: <20220412073131.10644-1-powen.kao@mediatek.com>

Hi, Po wen and Peter


I must give this patch Ack, because:

1. “fHPBReset Flag” can be sent in both host control mode and device
control mode. “buffer id=3 HpbWriteBuffer” can only be sent in device
control mode.

2. “fHPBReset Flag” inactivate all the regions for the whole device.
“buffer id=3 HpbWriteBuffer” can only inactivate all the regions for
this LUN. The LUN is written in the UPIU header.

In the ufshpb_init, we have set fHPBReset Flag. here doesn't need to
issue “buffer id=3 HpbWriteBuffer” in the case of device mode.

Regarding the reset flow issue we are talking about, I will submit a
fix.


Acked-by: Bean Huo <beanhuo@micron.com>


Bean



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-04-13 21:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  7:31 [PATCH 1/1] scsi: ufs: remove redundant HPB unmap Po-Wen Kao
2022-04-12  7:31 ` Po-Wen Kao
2022-04-12  7:31 ` Po-Wen Kao
2022-04-12 15:06 ` Bean Huo
2022-04-12 15:06   ` Bean Huo
2022-04-12 15:06   ` Bean Huo
2022-04-12 15:20   ` Bean Huo
2022-04-12 15:20     ` Bean Huo
2022-04-12 15:20     ` Bean Huo
2022-04-13  3:53     ` Peter Wang
2022-04-13 12:43       ` Bean Huo
2022-04-13 12:43         ` Bean Huo
2022-04-13 12:43         ` Bean Huo
2022-04-14  4:49     ` Po-Wen Kao
2022-04-14 22:07       ` Bean Huo
2022-04-14 22:07         ` Bean Huo
2022-04-14 22:07         ` Bean Huo
2022-04-13 21:29 ` Bean Huo [this message]
2022-04-13 21:29   ` Bean Huo
2022-04-13 21:29   ` Bean Huo
2022-04-26  4:00 ` Martin K. Petersen
2022-04-26  4:00   ` Martin K. Petersen
2022-04-26  4:00   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd403b025eb28186c3f05d682c383cb06e5b8ee.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=alice.chao@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cc.chou@mediatek.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=jason.li@sk.com \
    --cc=jejb@linux.ibm.com \
    --cc=jiajie.hao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    --cc=powen.kao@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    --cc=yohan.joung@sk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.