Re: [PATCH v1 4/4] Revert "arm64: dts: mt8173: add mmsel clocks for 4K support"

From: Matthias Brugger <matthias.bgg@gmail.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	matthias.bgg@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	Chen-Yu Tsai <wenst@chromium.org>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 4/4] Revert "arm64: dts: mt8173: add mmsel clocks for 4K support"
Date: Thu, 2 Mar 2023 12:03:16 +0100	[thread overview]
Message-ID: <dcd653a3-3f7c-7bfb-f096-033f62cb9074@gmail.com> (raw)
In-Reply-To: <3db45ca3-9104-826c-9f92-549e07471296@collabora.com>

On 10/02/2023 12:59, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 17:03, matthias.bgg@kernel.org ha scritto:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> This reverts commit fc6634ac0e5380aeb1063275a2e9a583d41b2306.
>>
>> The mmsys is a clock provider but does not have any clocks connected to
>> it. Therefore assigned-clock properties should be applied to the users of mmsys.
>>
>> This fixes the DT schema check:
>> mediatek/mt8173-elm.dtb: syscon@14000000: 'assigned-clock-rates', 
>> 'assigned-clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> About solving schema checks: agreed.
> 
> Since this is impacting on multiple subsystems (display, vdec, venc), can we
> instead move this to the topckgen node?
> I didn't check if that would trigger another schema check, but I remember
> doing that on Qualcomm DTs a bit of time ago.
> 
> The alternative would be to copy that over more than 10 nodes, which would
> be a bit ... ugly.
> 

Thanks Angelo and Chen-Yu for your feedback. I'm not able to reproduce that 
problem right now, so I'll drop this patch from the series.

Regards,
Matthias