From: Marek Vasut <marex@denx.de>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>,
arnd@arndb.de, robh+dt@kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
soc@kernel.org, Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
etienne.carriere@st.com
Subject: Re: [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure"
Date: Fri, 22 Apr 2022 18:31:25 +0200 [thread overview]
Message-ID: <dd48a7b5-ce08-5fb2-8236-8802ac91d827@denx.de> (raw)
In-Reply-To: <20220422150952.20587-3-alexandre.torgue@foss.st.com>
On 4/22/22 17:09, Alexandre Torgue wrote:
> In case of "st,stm32mp1-rcc-secure" (stm32mp1 clock driver with RCC
> security support hardened), "clocks" and "clock-names" describe oscillators
> and are required.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> index 7a251264582d..bb0e0b92e907 100644
> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> @@ -58,14 +58,8 @@ properties:
> - st,stm32mp1-rcc-secure
> - st,stm32mp1-rcc
> - const: syscon
> -
> - clocks:
> - description:
> - Specifies the external RX clock for ethernet MAC.
> - maxItems: 1
> -
> - clock-names:
> - const: ETH_RX_CLK/ETH_REF_CLK
> + clocks: true
> + clock-names: true
It looks like this should rather be a property than a compatible string
-- the compatible string is used by the OS to determine which hardware
is represented by a node, but here it is the same hardware in either
case, "st,stm32mp1-rcc" and "st,stm32mp1-rcc-secure", it is still the
same STM32MP1 RCC block, just configured differently by some bootloader
stage.
So why not just add one-liner property of the RCC block like ?
st,rcc-in-secure-configuration
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>,
arnd@arndb.de, robh+dt@kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
soc@kernel.org, Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
etienne.carriere@st.com
Subject: Re: [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure"
Date: Fri, 22 Apr 2022 18:31:25 +0200 [thread overview]
Message-ID: <dd48a7b5-ce08-5fb2-8236-8802ac91d827@denx.de> (raw)
In-Reply-To: <20220422150952.20587-3-alexandre.torgue@foss.st.com>
On 4/22/22 17:09, Alexandre Torgue wrote:
> In case of "st,stm32mp1-rcc-secure" (stm32mp1 clock driver with RCC
> security support hardened), "clocks" and "clock-names" describe oscillators
> and are required.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> index 7a251264582d..bb0e0b92e907 100644
> --- a/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp1-rcc.yaml
> @@ -58,14 +58,8 @@ properties:
> - st,stm32mp1-rcc-secure
> - st,stm32mp1-rcc
> - const: syscon
> -
> - clocks:
> - description:
> - Specifies the external RX clock for ethernet MAC.
> - maxItems: 1
> -
> - clock-names:
> - const: ETH_RX_CLK/ETH_REF_CLK
> + clocks: true
> + clock-names: true
It looks like this should rather be a property than a compatible string
-- the compatible string is used by the OS to determine which hardware
is represented by a node, but here it is the same hardware in either
case, "st,stm32mp1-rcc" and "st,stm32mp1-rcc-secure", it is still the
same STM32MP1 RCC block, just configured differently by some bootloader
stage.
So why not just add one-liner property of the RCC block like ?
st,rcc-in-secure-configuration
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-22 16:31 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 15:09 [PATCH 0/8] Add SCMI version of ST boards Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-04-22 15:09 ` [PATCH 1/8] dt-bindings: rcc: Add optional external ethernet RX clock properties Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-04-22 16:28 ` Marek Vasut
2022-04-22 16:28 ` Marek Vasut
2022-04-25 17:21 ` Alexandre TORGUE
2022-04-25 17:21 ` Alexandre TORGUE
2022-04-22 15:09 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Alexandre Torgue
2022-04-22 15:09 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st, stm32mp1-rcc-secure" Alexandre Torgue
2022-04-22 16:31 ` Marek Vasut [this message]
2022-04-22 16:31 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Marek Vasut
2022-04-25 19:11 ` Rob Herring
2022-04-25 19:11 ` Rob Herring
2022-04-25 19:35 ` Marek Vasut
2022-04-25 19:35 ` Marek Vasut
2022-04-26 18:44 ` Rob Herring
2022-04-26 18:44 ` Rob Herring
2022-05-02 21:13 ` Rob Herring
2022-05-02 21:13 ` Rob Herring
2022-05-05 14:11 ` Rob Herring
2022-05-05 14:11 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st, stm32mp1-rcc-secure" Rob Herring
2022-05-06 10:02 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Alexandre TORGUE
2022-05-06 10:02 ` Alexandre TORGUE
2022-05-06 16:21 ` Rob Herring
2022-05-06 16:21 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st, stm32mp1-rcc-secure" Rob Herring
2022-05-09 12:36 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Rob Herring
2022-05-09 12:36 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st, stm32mp1-rcc-secure" Rob Herring
2022-05-09 12:55 ` [PATCH 2/8] dt-bindings: clock: stm32mp1: describes clocks if "st,stm32mp1-rcc-secure" Alexandre TORGUE
2022-05-09 12:55 ` Alexandre TORGUE
2022-04-22 15:09 ` [PATCH 3/8] dt-bindings: clock: stm32mp15: rename CK_SCMI define Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-05-02 21:26 ` Rob Herring
2022-05-02 21:26 ` Rob Herring
2022-04-22 15:09 ` [PATCH 4/8] dt-bindings: reset: stm32mp15: rename RST_SCMI define Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-05-02 21:27 ` Rob Herring
2022-05-02 21:27 ` Rob Herring
2022-04-22 15:09 ` [PATCH 5/8] ARM: stm32: select OPTEE on MPU family Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-04-22 15:37 ` Ahmad Fatoum
2022-04-22 15:37 ` Ahmad Fatoum
2022-04-22 16:23 ` Alexandre TORGUE
2022-04-22 16:23 ` Alexandre TORGUE
2022-04-22 15:09 ` [PATCH 6/8] ARM: dts: stm32: enable optee firmware and SCMI support on STM32MP15 Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-04-22 16:32 ` Marek Vasut
2022-04-22 16:32 ` Marek Vasut
2022-04-25 10:19 ` Etienne CARRIERE
2022-04-25 10:19 ` Etienne CARRIERE
2022-04-25 10:25 ` Marek Vasut
2022-04-25 10:25 ` Marek Vasut
2022-04-25 10:30 ` Rouven Czerwinski
2022-04-25 10:30 ` Rouven Czerwinski
2022-04-22 15:09 ` [PATCH 7/8] dt-bindings: arm: stm32: Add SCMI version of STM32 boards (DK1/DK2/ED1/EV1) Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-05-02 21:28 ` Rob Herring
2022-05-02 21:28 ` Rob Herring
2022-04-22 15:09 ` [PATCH 8/8] ARM: dts: " Alexandre Torgue
2022-04-22 15:09 ` Alexandre Torgue
2022-05-03 14:51 ` [PATCH 0/8] Add SCMI version of ST boards Alexandre TORGUE
2022-05-03 14:51 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd48a7b5-ce08-5fb2-8236-8802ac91d827@denx.de \
--to=marex@denx.de \
--cc=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=etienne.carriere@st.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.