From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Oza Pawandeep <poza@codeaurora.org>,
linux-pci@vger.kernel.org, timur@codeaurora.org,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dongdong Liu <liudongdong3@huawei.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] PCI/AER: Dont do recovery when DPC is enabled
Date: Sun, 19 Nov 2017 11:41:01 -0500 [thread overview]
Message-ID: <dddb6c7a-5bf9-8c26-f753-6223b35f4842@codeaurora.org> (raw)
In-Reply-To: <20171118000243.GC16907@bhelgaas-glaptop.roam.corp.google.com>
On 11/17/2017 7:02 PM, Bjorn Helgaas wrote:
>> What do you think about the rescan following link up? The only entity
>> that does rescan today is hotplug after DPC recovery. There could be
>> a platform with DPC support but no hotplug support.
>>
>> How should we handle it?
> Good question. If your system does support both DPC and hotplug, I
> assume the link comes back up after you clear DPC Trigger Status.
> Does pciehp notice that "link up" event and add the device back?
that's correct. we see a link up indication from hotplug driver followed
by a rescan.
>
> So I think your question is whether the DPC code should explicitly do
> a rescan so that if we don't have pciehp, we'll still automatically
> rediscover the device. I dunno, maybe. Seems like a plausible idea
> anyway.
OK, will add it to DPC driver for completeness.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] PCI/AER: Dont do recovery when DPC is enabled
Date: Sun, 19 Nov 2017 11:41:01 -0500 [thread overview]
Message-ID: <dddb6c7a-5bf9-8c26-f753-6223b35f4842@codeaurora.org> (raw)
In-Reply-To: <20171118000243.GC16907@bhelgaas-glaptop.roam.corp.google.com>
On 11/17/2017 7:02 PM, Bjorn Helgaas wrote:
>> What do you think about the rescan following link up? The only entity
>> that does rescan today is hotplug after DPC recovery. There could be
>> a platform with DPC support but no hotplug support.
>>
>> How should we handle it?
> Good question. If your system does support both DPC and hotplug, I
> assume the link comes back up after you clear DPC Trigger Status.
> Does pciehp notice that "link up" event and add the device back?
that's correct. we see a link up indication from hotplug driver followed
by a rescan.
>
> So I think your question is whether the DPC code should explicitly do
> a rescan so that if we don't have pciehp, we'll still automatically
> rediscover the device. I dunno, maybe. Seems like a plausible idea
> anyway.
OK, will add it to DPC driver for completeness.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-19 16:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 4:56 [PATCH v2 0/4] PCI: query active service list Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` [PATCH v2 1/4] PCI: Add port service list node for pci_dev Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` [PATCH v2 2/4] PCI/portdrv: Add/Remove port services to the list Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` [PATCH v2 3/4] PCI/portdrv: Implement interface to query the registered service Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` [PATCH v2 4/4] PCI/AER: Dont do recovery when DPC is enabled Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 4:56 ` Oza Pawandeep
2017-11-15 21:14 ` Bjorn Helgaas
2017-11-15 21:14 ` Bjorn Helgaas
2017-11-15 21:14 ` Bjorn Helgaas
2017-11-16 14:03 ` Sinan Kaya
2017-11-16 14:03 ` Sinan Kaya
2017-11-16 20:17 ` Bjorn Helgaas
2017-11-16 20:17 ` Bjorn Helgaas
2017-11-16 20:17 ` Bjorn Helgaas
2017-11-16 20:52 ` Sinan Kaya
2017-11-16 20:52 ` Sinan Kaya
2017-11-18 0:02 ` Bjorn Helgaas
2017-11-18 0:02 ` Bjorn Helgaas
2017-11-18 0:02 ` Bjorn Helgaas
2017-11-19 16:41 ` Sinan Kaya [this message]
2017-11-19 16:41 ` Sinan Kaya
2017-11-21 16:25 ` David Laight
2017-11-21 16:25 ` David Laight
2017-11-21 16:25 ` David Laight
2017-11-21 16:43 ` Sinan Kaya
2017-11-21 16:43 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dddb6c7a-5bf9-8c26-f753-6223b35f4842@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.