* [PATCH] Makefile: allow to install libfdt without building executables
@ 2023-07-26 14:43 Nicolas Escande
[not found] ` <20230726144336.677135-1-nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Escande @ 2023-07-26 14:43 UTC (permalink / raw)
To: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA; +Cc: Nicolas Escande
When we only need the libfdt calling the target install-lib also builds the
executables listed in $(BINS) because this target depends on all
Instead lets make install-lib only depend on libfdt.
Signed-off-by: Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 784e2f8..c0b68a2 100644
--- a/Makefile
+++ b/Makefile
@@ -238,7 +238,7 @@ install-bin: all $(SCRIPTS)
$(INSTALL_PROGRAM) $(BIN) $(DESTDIR)$(BINDIR)
$(INSTALL_SCRIPT) $(SCRIPTS) $(DESTDIR)$(BINDIR)
-install-lib: all
+install-lib: libfdt
@$(VECHO) INSTALL-LIB
$(INSTALL) -d $(DESTDIR)$(LIBDIR)
$(INSTALL_LIB) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: allow to install libfdt without building executables
[not found] ` <20230726144336.677135-1-nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2023-07-27 0:49 ` Simon Glass
[not found] ` <CAPnjgZ1OZBF6YWUCrKUW1FEHaR4EzZMGVn00k62vcQSA91ubzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-07-29 3:08 ` David Gibson
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2023-07-27 0:49 UTC (permalink / raw)
To: Nicolas Escande; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
On Wed, 26 Jul 2023 at 08:44, Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> When we only need the libfdt calling the target install-lib also builds the
> executables listed in $(BINS) because this target depends on all
> Instead lets make install-lib only depend on libfdt.
>
> Signed-off-by: Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
But why would you just want the libs?
>
> diff --git a/Makefile b/Makefile
> index 784e2f8..c0b68a2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -238,7 +238,7 @@ install-bin: all $(SCRIPTS)
> $(INSTALL_PROGRAM) $(BIN) $(DESTDIR)$(BINDIR)
> $(INSTALL_SCRIPT) $(SCRIPTS) $(DESTDIR)$(BINDIR)
>
> -install-lib: all
> +install-lib: libfdt
> @$(VECHO) INSTALL-LIB
> $(INSTALL) -d $(DESTDIR)$(LIBDIR)
> $(INSTALL_LIB) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: allow to install libfdt without building executables
[not found] ` <CAPnjgZ1OZBF6YWUCrKUW1FEHaR4EzZMGVn00k62vcQSA91ubzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2023-07-27 8:45 ` Nicolas Escande
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Escande @ 2023-07-27 8:45 UTC (permalink / raw)
To: Simon Glass; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
On Thu Jul 27, 2023 at 2:49 AM CEST, Simon Glass wrote:
> On Wed, 26 Jul 2023 at 08:44, Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> >
> > When we only need the libfdt calling the target install-lib also builds the
> > executables listed in $(BINS) because this target depends on all
> > Instead lets make install-lib only depend on libfdt.
> >
> > Signed-off-by: Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> But why would you just want the libs?
>
Well some projects like qemu & uboot from the top of my head use the libfdt and
do not always need/build the dtc that goes with it.
It's cleary very corner case but I don't think it harms anyone doing so :)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile: allow to install libfdt without building executables
[not found] ` <20230726144336.677135-1-nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2023-07-27 0:49 ` Simon Glass
@ 2023-07-29 3:08 ` David Gibson
1 sibling, 0 replies; 4+ messages in thread
From: David Gibson @ 2023-07-29 3:08 UTC (permalink / raw)
To: Nicolas Escande; +Cc: devicetree-compiler-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Wed, Jul 26, 2023 at 04:43:11PM +0200, Nicolas Escande wrote:
> When we only need the libfdt calling the target install-lib also builds the
> executables listed in $(BINS) because this target depends on all
> Instead lets make install-lib only depend on libfdt.
>
> Signed-off-by: Nicolas Escande <nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Merged, thanks.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 784e2f8..c0b68a2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -238,7 +238,7 @@ install-bin: all $(SCRIPTS)
> $(INSTALL_PROGRAM) $(BIN) $(DESTDIR)$(BINDIR)
> $(INSTALL_SCRIPT) $(SCRIPTS) $(DESTDIR)$(BINDIR)
>
> -install-lib: all
> +install-lib: libfdt
> @$(VECHO) INSTALL-LIB
> $(INSTALL) -d $(DESTDIR)$(LIBDIR)
> $(INSTALL_LIB) $(LIBFDT_lib) $(DESTDIR)$(LIBDIR)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-29 3:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 14:43 [PATCH] Makefile: allow to install libfdt without building executables Nicolas Escande
[not found] ` <20230726144336.677135-1-nico.escande-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2023-07-27 0:49 ` Simon Glass
[not found] ` <CAPnjgZ1OZBF6YWUCrKUW1FEHaR4EzZMGVn00k62vcQSA91ubzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2023-07-27 8:45 ` Nicolas Escande
2023-07-29 3:08 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).