From: Bart Van Assche <bvanassche@acm.org>
To: Martin Wilck <mwilck@suse.com>, Mike Snitzer <snitzer@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
emilne@redhat.com, linux-block@vger.kernel.org,
dm-devel@redhat.com, nkoenig@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v4 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status()
Date: Wed, 30 Jun 2021 15:08:11 -0700 [thread overview]
Message-ID: <1c05c65e-64a2-0584-1888-1f544998365e@acm.org> (raw)
In-Reply-To: <da3039c75c892f7d4031161f7c8719e50de36057.camel@suse.com>
On 6/30/21 9:54 AM, Martin Wilck wrote:
> @Martin, @Bart, do you have a suggestion for me?
The code in block/scsi_ioctl.c exists in the block layer since until
recently most of it was used by both the IDE and SCSI code. Now that
drivers/ide is gone (thanks Christoph!), how about moving block/bsg.c
and block/scsi_ioctl.c to drivers/scsi/? As far as I can see the BSG
code is only used by SCSI drivers:
$ git grep -nH BLK_DEV_BSG | grep /Kconfig
block/Kconfig:38:config BLK_DEV_BSG
block/Kconfig:57:config BLK_DEV_BSGLIB
block/Kconfig:59: select BLK_DEV_BSG
drivers/scsi/Kconfig:231: select BLK_DEV_BSGLIB
drivers/scsi/Kconfig:241: select BLK_DEV_BSGLIB
drivers/scsi/Kconfig:250: select BLK_DEV_BSGLIB
drivers/scsi/libsas/Kconfig:13: select BLK_DEV_BSGLIB
drivers/scsi/ufs/Kconfig:150: select BLK_DEV_BSGLIB
The block/scsi_ioctl.c code is used more widely however:
$ git grep -nH BLK_SCSI_REQUEST | grep /Kconfig
block/Kconfig:32:config BLK_SCSI_REQUEST
block/Kconfig:41: select BLK_SCSI_REQUEST
block/Kconfig:60: select BLK_SCSI_REQUEST
drivers/block/Kconfig:77: select BLK_SCSI_REQUEST
drivers/block/Kconfig:309: select BLK_SCSI_REQUEST
drivers/block/paride/Kconfig:30: select BLK_SCSI_REQUEST
drivers/scsi/Kconfig:22: select BLK_SCSI_REQUEST
drivers/target/Kconfig:8: select BLK_SCSI_REQUEST
fs/nfsd/Kconfig:112: select BLK_SCSI_REQUEST
Bart.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-30 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:52 [dm-devel] [PATCH v4 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck
2021-06-28 9:52 ` [dm-devel] [PATCH v4 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck
2021-06-28 9:53 ` Christoph Hellwig
2021-06-28 14:57 ` Martin Wilck
2021-06-29 12:59 ` Christoph Hellwig
2021-06-29 19:23 ` Martin Wilck
2021-06-29 21:23 ` Keith Busch
2021-06-30 8:12 ` Martin Wilck
2021-06-30 16:01 ` Mike Snitzer
2021-06-30 16:54 ` Martin Wilck
2021-06-30 22:08 ` Bart Van Assche [this message]
2021-07-01 6:19 ` Christoph Hellwig
2021-07-06 16:40 ` Paolo Bonzini
2021-06-28 9:52 ` [dm-devel] [PATCH v4 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status() mwilck
2021-06-28 14:39 ` kernel test robot
2021-06-29 7:00 ` [dm-devel] [kbuild] " Dan Carpenter
2021-06-28 9:52 ` [dm-devel] [PATCH v4 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c05c65e-64a2-0584-1888-1f544998365e@acm.org \
--to=bvanassche@acm.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=nkoenig@redhat.com \
--cc=pbonzini@redhat.com \
--cc=snitzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).