From: Martin Wilck <mwilck@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Mike Snitzer <snitzer@redhat.com>,
linux-scsi@vger.kernel.org, emilne@redhat.com,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
nkoenig@redhat.com, Bart Van Assche <Bart.VanAssche@sandisk.com>,
Daniel Wagner <dwagner@suse.de>,
Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v4 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status()
Date: Tue, 29 Jun 2021 21:23:18 +0200 [thread overview]
Message-ID: <2b5fd35d95668a8cba9151941c058cb8aee3e37c.camel@suse.com> (raw)
In-Reply-To: <20210629125909.GB14372@lst.de>
On Di, 2021-06-29 at 14:59 +0200, Christoph Hellwig wrote:
> On Mon, Jun 28, 2021 at 04:57:33PM +0200, Martin Wilck wrote:
>
> > The sg_io-on-multipath code needs to answer the question "is this a
> > path or a target error?". Therefore it calls blk_path_error(),
> > which
> > requires obtaining a blk_status_t first. But that's not available
> > in
> > the sg_io code path. So how should I deal with this situation?
>
> Not by exporting random crap from the SCSI code.
So, you'd prefer inlining scsi_result_to_blk_status()?
Thanks,
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-29 19:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:52 [dm-devel] [PATCH v4 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck
2021-06-28 9:52 ` [dm-devel] [PATCH v4 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck
2021-06-28 9:53 ` Christoph Hellwig
2021-06-28 14:57 ` Martin Wilck
2021-06-29 12:59 ` Christoph Hellwig
2021-06-29 19:23 ` Martin Wilck [this message]
2021-06-29 21:23 ` Keith Busch
2021-06-30 8:12 ` Martin Wilck
2021-06-30 16:01 ` Mike Snitzer
2021-06-30 16:54 ` Martin Wilck
2021-06-30 22:08 ` Bart Van Assche
2021-07-01 6:19 ` Christoph Hellwig
2021-07-06 16:40 ` Paolo Bonzini
2021-06-28 9:52 ` [dm-devel] [PATCH v4 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status() mwilck
2021-06-28 14:39 ` kernel test robot
2021-06-29 7:00 ` [dm-devel] [kbuild] " Dan Carpenter
2021-06-28 9:52 ` [dm-devel] [PATCH v4 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b5fd35d95668a8cba9151941c058cb8aee3e37c.camel@suse.com \
--to=mwilck@suse.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nkoenig@redhat.com \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).