From: mwilck@suse.com
To: Mike Snitzer <snitzer@redhat.com>,
Alasdair G Kergon <agk@redhat.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, dm-devel@redhat.com,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: Daniel Wagner <dwagner@suse.de>,
emilne@redhat.com, linux-block@vger.kernel.org,
nkoenig@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Martin Wilck <mwilck@suse.com>
Subject: [dm-devel] [PATCH v5 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status()
Date: Mon, 28 Jun 2021 17:15:57 +0200 [thread overview]
Message-ID: <20210628151558.2289-3-mwilck@suse.com> (raw)
In-Reply-To: <20210628151558.2289-1-mwilck@suse.com>
From: Martin Wilck <mwilck@suse.com>
This helper converts the SCSI result in a sg_io_hdr struct to a blk_status_t.
It will be used in the SG_IO code path for dm-multipath. Putting it into
scsi_ioctl.c avoids open-coding SCSI specific code in the dm layer.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
block/scsi_ioctl.c | 20 ++++++++++++++++++++
include/linux/blkdev.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 19b63b64ecbc..e061398be90f 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -929,6 +929,26 @@ blk_status_t __scsi_result_to_blk_status(int *cmd_result, int result)
}
EXPORT_SYMBOL(__scsi_result_to_blk_status);
+blk_status_t sg_io_to_blk_status(struct sg_io_hdr *hdr)
+{
+ int result;
+ blk_status_t sts;
+
+ if (!(hdr->info & SG_INFO_CHECK))
+ return BLK_STS_OK;
+
+ result = hdr->status |
+ (hdr->msg_status << 8) |
+ (hdr->host_status << 16) |
+ (hdr->driver_status << 24);
+
+ sts = __scsi_result_to_blk_status(&result, result);
+ hdr->host_status = host_byte(result);
+
+ return sts;
+}
+EXPORT_SYMBOL(sg_io_to_blk_status);
+
static int __init blk_scsi_ioctl_init(void)
{
blk_set_cmd_filter_defaults(&blk_default_cmd_filter);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 48497a77428d..5da03edf125c 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -2022,4 +2022,5 @@ int freeze_bdev(struct block_device *bdev);
int thaw_bdev(struct block_device *bdev);
blk_status_t __scsi_result_to_blk_status(int *cmd_result, int result);
+blk_status_t sg_io_to_blk_status(struct sg_io_hdr *hdr);
#endif /* _LINUX_BLKDEV_H */
--
2.32.0
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-28 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 15:15 [dm-devel] [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck
2021-06-28 15:15 ` [dm-devel] [PATCH v5 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck
2021-06-28 15:15 ` mwilck [this message]
2021-06-28 15:15 ` [dm-devel] [PATCH v5 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck
2021-07-01 7:56 ` Christoph Hellwig
2021-07-01 10:35 ` Martin Wilck
2021-07-01 11:34 ` Christoph Hellwig
2021-07-02 14:21 ` Martin Wilck
2021-07-05 13:02 ` Paolo Bonzini
2021-07-05 13:11 ` Hannes Reinecke
2021-07-05 13:48 ` Martin Wilck
2021-07-06 10:13 ` Paolo Bonzini
2021-07-01 11:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210628151558.2289-3-mwilck@suse.com \
--to=mwilck@suse.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nkoenig@redhat.com \
--cc=pbonzini@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).