dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Martin Wilck <mwilck@suse.com>, Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
	Mike Snitzer <snitzer@redhat.com>,
	emilne@redhat.com, linux-block@vger.kernel.org,
	dm-devel@redhat.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	nkoenig@redhat.com, Bart Van Assche <Bart.VanAssche@sandisk.com>,
	Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v5 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO
Date: Mon, 5 Jul 2021 15:02:08 +0200	[thread overview]
Message-ID: <e6d76740-e0ed-861a-ef0c-959e738c3ef5@redhat.com> (raw)
In-Reply-To: <003727e7a195cb0f525cc2d7abda3a19ff16eb98.camel@suse.com>

On 02/07/21 16:21, Martin Wilck wrote:
>> SG_IO gives you raw access to the SCSI logic unit, and you get to
>> keep the pieces if anything goes wrong.
> 
> That's a very fragile user space API, on the fringe of being useless
> IMO.

Indeed.  If SG_IO is for raw access to an ITL nexus, it shouldn't be
supported at all by mpath devices.  If on the other hand SG_IO is for
raw access to a LUN, there is no reason for it to not support failover.

Paolo

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-07-05 13:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 15:15 [dm-devel] [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck
2021-06-28 15:15 ` [dm-devel] [PATCH v5 1/3] scsi: scsi_ioctl: export __scsi_result_to_blk_status() mwilck
2021-06-28 15:15 ` [dm-devel] [PATCH v5 2/3] scsi: scsi_ioctl: add sg_io_to_blk_status() mwilck
2021-06-28 15:15 ` [dm-devel] [PATCH v5 3/3] dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO mwilck
2021-07-01  7:56   ` Christoph Hellwig
2021-07-01 10:35     ` Martin Wilck
2021-07-01 11:34       ` Christoph Hellwig
2021-07-02 14:21         ` Martin Wilck
2021-07-05 13:02           ` Paolo Bonzini [this message]
2021-07-05 13:11             ` Hannes Reinecke
2021-07-05 13:48               ` Martin Wilck
2021-07-06 10:13                 ` Paolo Bonzini
2021-07-01 11:06     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6d76740-e0ed-861a-ef0c-959e738c3ef5@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=dwagner@suse.de \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=nkoenig@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).