* [dm-devel] Patch "dm: remove flush_scheduled_work() during local_exit()" has been added to the 6.2-stable tree
@ 2023-03-05 2:19 Sasha Levin
0 siblings, 0 replies; only message in thread
From: Sasha Levin @ 2023-03-05 2:19 UTC (permalink / raw)
To: stable-commits, snitzer; +Cc: dm-devel, Alasdair Kergon
This is a note to let you know that I've just added the patch titled
dm: remove flush_scheduled_work() during local_exit()
to the 6.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dm-remove-flush_scheduled_work-during-local_exit.patch
and it can be found in the queue-6.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
commit f30ccd148db854f9a1534c1e05e83ddb20a71f8e
Author: Mike Snitzer <snitzer@kernel.org>
Date: Tue Feb 14 13:06:05 2023 -0500
dm: remove flush_scheduled_work() during local_exit()
[ Upstream commit 0b22ff5360f5c4e11050b89206370fdf7dc0a226 ]
Commit acfe0ad74d2e1 ("dm: allocate a special workqueue for deferred
device removal") switched from using system workqueue to a single
workqueue local to DM. But it didn't eliminate the call to
flush_scheduled_work() that was introduced purely for the benefit of
deferred device removal with commit 2c140a246dc ("dm: allow remove to
be deferred").
Since DM core uses its own workqueue (and queue_work) there is no need
to call flush_scheduled_work() from local_exit(). local_exit()'s
destroy_workqueue(deferred_remove_workqueue) handles flushing work
started with queue_work().
Fixes: acfe0ad74d2e1 ("dm: allocate a special workqueue for deferred device removal")
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index b424a6ee27baf..eba9bc06856bf 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -231,7 +231,6 @@ static int __init local_init(void)
static void local_exit(void)
{
- flush_scheduled_work();
destroy_workqueue(deferred_remove_workqueue);
unregister_blkdev(_major, _name);
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-03-05 2:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-05 2:19 [dm-devel] Patch "dm: remove flush_scheduled_work() during local_exit()" has been added to the 6.2-stable tree Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).