* [dm-devel] [PATCH] dm-writecache: write at least 4k when committing
@ 2021-06-21 18:48 Mikulas Patocka
0 siblings, 0 replies; only message in thread
From: Mikulas Patocka @ 2021-06-21 18:48 UTC (permalink / raw)
To: Mike Snitzer, Alasdair Kergon; +Cc: dm-devel
SSDs perform badly with sub-4k writes (because they perfrorm
read-modify-write internally), so make sure that we write at least 4k when
committing.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Fixes: 991bd8d7bc78 ("dm writecache: commit just one block, not a full page")
Index: linux/drivers/md/dm-writecache.c
===================================================================
--- linux.orig/drivers/md/dm-writecache.c
+++ linux/drivers/md/dm-writecache.c
@@ -533,7 +533,11 @@ static void ssd_commit_superblock(struct
region.bdev = wc->ssd_dev->bdev;
region.sector = 0;
- region.count = wc->block_size >> SECTOR_SHIFT;
+ region.count = max(4096U, wc->block_size) >> SECTOR_SHIFT;
+
+ if (unlikely(region.sector + region.count > wc->metadata_sectors))
+ region.count = wc->metadata_sectors - region.sector;
+
region.sector += wc->start_sector;
req.bi_op = REQ_OP_WRITE;
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-21 18:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 18:48 [dm-devel] [PATCH] dm-writecache: write at least 4k when committing Mikulas Patocka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).