* [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets
@ 2023-03-31 8:28 mwilck
2023-03-31 13:47 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: mwilck @ 2023-03-31 8:28 UTC (permalink / raw)
To: Christophe Varoqui, Benjamin Marzinski, lixiaokeng; +Cc: dm-devel, Martin Wilck
From: Martin Wilck <mwilck@suse.com>
When we set the check to something other than TUR, we need
to disable checker detection, too.
Signed-off-by: Martin Wilck <mwilck@suse.com>
---
libmultipath/hwtable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index c2a024c..65bca74 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1068,6 +1068,7 @@ static struct hwentry default_hw[] = {
.no_path_retry = 12,
.prio_name = PRIO_ALUA,
.checker_name = DIRECTIO,
+ .detect_checker = DETECT_CHECKER_OFF,
},
/*
* DataCore
--
2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets
2023-03-31 8:28 [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets mwilck
@ 2023-03-31 13:47 ` Benjamin Marzinski
2023-03-31 15:19 ` Martin Wilck
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Marzinski @ 2023-03-31 13:47 UTC (permalink / raw)
To: mwilck; +Cc: lixiaokeng, dm-devel
On Fri, Mar 31, 2023 at 10:28:35AM +0200, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> When we set the check to something other than TUR, we need
> to disable checker detection, too.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/hwtable.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index c2a024c..65bca74 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1068,6 +1068,7 @@ static struct hwentry default_hw[] = {
> .no_path_retry = 12,
> .prio_name = PRIO_ALUA,
> .checker_name = DIRECTIO,
> + .detect_checker = DETECT_CHECKER_OFF,
> },
> /*
> * DataCore
> --
> 2.39.2
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets
2023-03-31 13:47 ` Benjamin Marzinski
@ 2023-03-31 15:19 ` Martin Wilck
0 siblings, 0 replies; 3+ messages in thread
From: Martin Wilck @ 2023-03-31 15:19 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: lixiaokeng, dm-devel
On Fri, 2023-03-31 at 08:47 -0500, Benjamin Marzinski wrote:
> On Fri, Mar 31, 2023 at 10:28:35AM +0200, mwilck@suse.com wrote:
> > From: Martin Wilck <mwilck@suse.com>
> >
> > When we set the check to something other than TUR, we need
> > to disable checker detection, too.
> >
> > Signed-off-by: Martin Wilck <mwilck@suse.com>
>
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Thanks! I am going to squash this in.
Martin
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-31 8:28 [dm-devel] [PATCH] fixup! libmultipath: use directio checker for LIO targets mwilck
2023-03-31 13:47 ` Benjamin Marzinski
2023-03-31 15:19 ` Martin Wilck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).