From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
Vijayendra Suman <vijayendra.suman@oracle.com>,
dm-devel@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v3 3/6] block: use lcm_not_zero() when stacking chunk_sectors
Date: Tue, 22 Sep 2020 15:28:51 -0400 [thread overview]
Message-ID: <yq13639r4po.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200922023251.47712-4-snitzer@redhat.com> (Mike Snitzer's message of "Mon, 21 Sep 2020 22:32:48 -0400")
Mike,
> Like 'io_opt', blk_stack_limits() should stack 'chunk_sectors' using
> lcm_not_zero() rather than min_not_zero() -- otherwise the final
> 'chunk_sectors' could result in sub-optimal alignment of IO to
> component devices in the IO stack.
>
> Also, if 'chunk_sectors' isn't a multiple of 'physical_block_size'
> then it is a bug in the driver and the device should be flagged as
> 'misaligned'.
Looks good.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-09-22 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 2:32 [PATCH v3 0/6] dm: fix then improve bio splitting Mike Snitzer
2020-09-22 2:32 ` [PATCH v3 1/6] dm: fix bio splitting and its bio completion order for regular IO Mike Snitzer
2020-09-22 2:32 ` [PATCH v3 2/6] dm: fix comment in dm_process_bio() Mike Snitzer
2020-09-22 2:32 ` [PATCH v3 3/6] block: use lcm_not_zero() when stacking chunk_sectors Mike Snitzer
2020-09-22 19:28 ` Martin K. Petersen [this message]
2020-09-22 2:32 ` [PATCH v3 4/6] block: allow 'chunk_sectors' to be non-power-of-2 Mike Snitzer
2020-09-22 19:30 ` Martin K. Petersen
2020-09-22 2:32 ` [PATCH v3 5/6] dm table: stack 'chunk_sectors' limit to account for target-specific splitting Mike Snitzer
2020-09-22 2:32 ` [PATCH v3 6/6] dm: change max_io_len() to use blk_max_size_offset() Mike Snitzer
2020-09-23 16:38 ` [PATCH v3 0/6] dm: fix then improve bio splitting Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq13639r4po.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=snitzer@redhat.com \
--cc=vijayendra.suman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).