From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: <robh+dt@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>,
<dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<grygorii.strashko@ti.com>, <lokeshvutla@ti.com>,
<t-kristo@ti.com>, <tony@atomide.com>, <j-keerthy@ti.com>
Subject: Re: [PATCH v4 09/15] dmaengine: ti: New driver for K3 UDMA - split#1: defines, structs, io func
Date: Mon, 11 Nov 2019 10:33:12 +0200 [thread overview]
Message-ID: <00777586-a3ac-2404-5226-e8c887936a32@ti.com> (raw)
In-Reply-To: <20191111052828.GN952516@vkoul-mobl>
On 11/11/2019 7.28, Vinod Koul wrote:
> On 01-11-19, 10:41, Peter Ujfalusi wrote:
>
>> +struct udma_chan {
>> + struct virt_dma_chan vc;
>> + struct dma_slave_config cfg;
>> + struct udma_dev *ud;
>> + struct udma_desc *desc;
>> + struct udma_desc *terminated_desc;
>
> descriptor and not a list?
Yes, not a list. I have only one transfer (if any) submitted to
hardware. This is mostly due to the packet mode RX operation: no
prelinked support in UDMAP so I need to have as many descriptors queued
up as the number of sg elements.
I need to keep the terminated descriptor around to be able to free it up
_after_ UDMAP returned it to avoid it modifying released memory.
>> + struct udma_static_tr static_tr;
>> + char *name;
>> +
>> + struct udma_tchan *tchan;
>> + struct udma_rchan *rchan;
>> + struct udma_rflow *rflow;
>> +
>> + bool psil_paired;
>> +
>> + int irq_num_ring;
>> + int irq_num_udma;
>> +
>> + bool cyclic;
>> + bool paused;
>> +
>> + enum udma_chan_state state;
>> + struct completion teardown_completed;
>> +
>> + u32 bcnt; /* number of bytes completed since the start of the channel */
>> + u32 in_ring_cnt; /* number of descriptors in flight */
>> +
>> + bool pkt_mode; /* TR or packet */
>> + bool needs_epib; /* EPIB is needed for the communication or not */
>> + u32 psd_size; /* size of Protocol Specific Data */
>> + u32 metadata_size; /* (needs_epib ? 16:0) + psd_size */
>> + u32 hdesc_size; /* Size of a packet descriptor in packet mode */
>> + bool notdpkt; /* Suppress sending TDC packet */
>> + int remote_thread_id;
>> + u32 src_thread;
>> + u32 dst_thread;
>> + enum psil_endpoint_type ep_type;
>> + bool enable_acc32;
>> + bool enable_burst;
>> + enum udma_tp_level channel_tpl; /* Channel Throughput Level */
>> +
>> + /* dmapool for packet mode descriptors */
>> + bool use_dma_pool;
>> + struct dma_pool *hdesc_pool;
>> +
>> + u32 id;
>> + enum dma_transfer_direction dir;
>
> why does channel have this, it already exists in descriptor
The channel can not change role, it is set when it was requested. In the
prep callbacks I do check if the direction matches with the channel's
direction.
>> +static irqreturn_t udma_udma_irq_handler(int irq, void *data)
>> +{
>> + struct udma_chan *uc = data;
>> +
>> + udma_tr_event_callback(uc);
>
> any reason why we want to call a fn and not code here..?
No particular reason, I'll move them.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-11 8:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 8:41 [PATCH v4 00/15] dmaengine/soc: Add Texas Instruments UDMA support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 01/15] bindings: soc: ti: add documentation for k3 ringacc Peter Ujfalusi
2019-11-11 4:07 ` Vinod Koul
2019-11-11 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 02/15] soc: ti: k3: add navss ringacc driver Peter Ujfalusi
2019-11-11 4:21 ` Vinod Koul
2019-11-11 7:39 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 03/15] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 04/15] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 05/15] dmaengine: Add support for reporting DMA cached data amount Peter Ujfalusi
2019-11-11 4:39 ` Vinod Koul
2019-11-11 8:00 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 06/15] dmaengine: ti: Add cppi5 header for K3 NAVSS/UDMA Peter Ujfalusi
2019-11-05 7:40 ` Tero Kristo
2019-11-01 8:41 ` [PATCH v4 07/15] dmaengine: ti: k3 PSI-L remote endpoint configuration Peter Ujfalusi
2019-11-05 7:49 ` Tero Kristo
2019-11-05 8:13 ` Peter Ujfalusi
2019-11-05 10:00 ` Grygorii Strashko
2019-11-05 10:27 ` Peter Ujfalusi
2019-11-05 11:25 ` Grygorii Strashko
2019-11-11 4:47 ` Vinod Koul
2019-11-11 8:47 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 08/15] dt-bindings: dma: ti: Add document for K3 UDMA Peter Ujfalusi
2019-11-05 2:19 ` Rob Herring
2019-11-05 10:08 ` Peter Ujfalusi
2019-11-14 17:53 ` Rob Herring
2019-11-15 9:45 ` Peter Ujfalusi
2019-11-26 8:29 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 09/15] dmaengine: ti: New driver for K3 UDMA - split#1: defines, structs, io func Peter Ujfalusi
2019-11-11 5:28 ` Vinod Koul
2019-11-11 8:33 ` Peter Ujfalusi [this message]
2019-11-11 9:00 ` Vinod Koul
2019-11-11 9:12 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 10/15] dmaengine: ti: New driver for K3 UDMA - split#2: probe/remove, xlate and filter_fn Peter Ujfalusi
2019-11-11 5:33 ` Vinod Koul
2019-11-11 9:16 ` Peter Ujfalusi
2019-11-12 5:34 ` Vinod Koul
2019-11-12 7:22 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 11/15] dmaengine: ti: New driver for K3 UDMA - split#3: alloc/free chan_resources Peter Ujfalusi
2019-11-11 6:06 ` Vinod Koul
2019-11-11 9:40 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 12/15] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1 Peter Ujfalusi
2019-11-11 6:09 ` Vinod Koul
2019-11-11 10:29 ` Peter Ujfalusi
2019-11-12 5:36 ` Vinod Koul
2019-11-12 7:24 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 13/15] dmaengine: ti: New driver for K3 UDMA - split#5: dma_device callbacks 2 Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 14/15] dmaengine: ti: New driver for K3 UDMA - split#6: Kconfig and Makefile Peter Ujfalusi
2019-11-11 6:11 ` Vinod Koul
2019-11-11 10:30 ` Peter Ujfalusi
2019-11-01 8:41 ` [PATCH v4 15/15] dmaengine: ti: k3-udma: Add glue layer for non DMAengine users Peter Ujfalusi
2019-11-11 6:12 ` Vinod Koul
2019-11-11 10:31 ` Peter Ujfalusi
2019-11-12 5:37 ` Vinod Koul
2019-11-12 7:25 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00777586-a3ac-2404-5226-e8c887936a32@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).