[PATCH 00/24] MODULE_LICENSE removals, second tranche

[PATCH 00/24] MODULE_LICENSE removals, second tranche

[Nick Alcock]

This series, based on current modules-next, is part of a treewide cleanup
suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
files/objects that are not tristate.  Due to recent changes to kbuild, these
uses are now problematic.  See the commit logs for more details.

(The commit log prefixes and Cc lists are automatically determined using
the script mentioned below.  I've eyeballed them, and they seem reasonable:
my apologies if they are not.)

I'll be sending a third 24-patch tranche in a few days if this one
doesn't blow up.

(In total, there are 121 patches in this series.)


The series at a whole can be found here:
  https://github.com/nickalcock/linux module-license

The patch splitter (not for upstreaming!) used to prepare these
commits can be found here:
  https://github.com/nickalcock/linux mass-split

Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: asahi@lists.linux.dev
Cc: dmaengine@vger.kernel.org
Cc: linux-acpi@vger.kernel.org
Cc: linux-actions@lists.infradead.org
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-clk@vger.kernel.org
Cc: linux-edac@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-gpio@vger.kernel.org 
Cc: linux-kernel@vger.kernel.org
Cc: linux-modules@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-serial@vger.kernel.org
Cc: linux-sunxi@lists.linux.dev
Cc: linux-tegra@vger.kernel.org

Nick Alcock (24):
  kbuild, soc: fujitsu: remove MODULE_LICENSE in non-modules
  kbuild, PCI: remove MODULE_LICENSE in non-modules
  kbuild, mfd: altera-sysmgr: remove MODULE_LICENSE in non-modules
  kbuild, irqchip/al-fic: remove MODULE_LICENSE in non-modules
  kbuild, cpufreq: amd-pstate: remove MODULE_LICENSE in non-modules
  kbuild, binder: remove MODULE_LICENSE in non-modules
  kbuild, bus: arm-integrator-lm: remove MODULE_LICENSE in non-modules
  kbuild, drivers/perf: remove MODULE_LICENSE in non-modules
  kbuild, ARM: tegra: remove MODULE_LICENSE in non-modules
  kbuild, pinctrl: actions: remove MODULE_LICENSE in non-modules
  kbuild, soc: apple: apple-pmgr-pwrstate: remove MODULE_LICENSE in
    non-modules
  kbuild, soc: sunxi: sram: remove MODULE_LICENSE in non-modules
  kbuild, clk: bm1880: remove MODULE_LICENSE in non-modules
  kbuild, firmware: imx: remove MODULE_LICENSE in non-modules
  kbuild, bus: ixp4xx: remove MODULE_LICENSE in non-modules
  kbuild, irqchip/mvebu-pic: remove MODULE_LICENSE in non-modules
  kbuild, pinctrl: nuvoton: npcm7xx: remove MODULE_LICENSE in
    non-modules
  kbuild, bus: qcom: remove MODULE_LICENSE in non-modules
  kbuild, bus: remove MODULE_LICENSE in non-modules
  kbuild, gpio: remove MODULE_LICENSE in non-modules
  kbuild, serial: remove MODULE_LICENSE in non-modules
  kbuild, dmaengine: s3c24xx: remove MODULE_LICENSE in non-modules
  kbuild, EDAC, altera: remove MODULE_LICENSE in non-modules
  kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in
    non-modules

 drivers/amba/tegra-ahb.c                  | 1 -
 drivers/android/binder.c                  | 1 -
 drivers/bus/arm-integrator-lm.c           | 1 -
 drivers/bus/imx-weim.c                    | 1 -
 drivers/bus/intel-ixp4xx-eb.c             | 1 -
 drivers/bus/qcom-ebi2.c                   | 1 -
 drivers/bus/qcom-ssc-block-bus.c          | 1 -
 drivers/clk/clk-bm1880.c                  | 1 -
 drivers/cpufreq/amd-pstate.c              | 1 -
 drivers/dma/s3c24xx-dma.c                 | 1 -
 drivers/edac/altera_edac.c                | 1 -
 drivers/firmware/imx/imx-scu.c            | 1 -
 drivers/firmware/imx/scu-pd.c             | 1 -
 drivers/gpio/gpio-rda.c                   | 1 -
 drivers/irqchip/irq-al-fic.c              | 1 -
 drivers/irqchip/irq-mvebu-pic.c           | 1 -
 drivers/mfd/altera-sysmgr.c               | 1 -
 drivers/pci/hotplug/acpiphp_core.c        | 1 -
 drivers/perf/apple_m1_cpu_pmu.c           | 1 -
 drivers/pinctrl/actions/pinctrl-s500.c    | 1 -
 drivers/pinctrl/actions/pinctrl-s700.c    | 1 -
 drivers/pinctrl/actions/pinctrl-s900.c    | 1 -
 drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 1 -
 drivers/power/reset/keystone-reset.c      | 1 -
 drivers/soc/apple/apple-pmgr-pwrstate.c   | 1 -
 drivers/soc/fujitsu/a64fx-diag.c          | 1 -
 drivers/soc/sunxi/sunxi_sram.c            | 1 -
 drivers/tty/serial/rda-uart.c             | 1 -
 28 files changed, 28 deletions(-)

-- 
2.39.1.268.g9de2f9a303

[PATCH 22/24] kbuild, dmaengine: s3c24xx: remove MODULE_LICENSE in non-modules

[Nick Alcock]

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/s3c24xx-dma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/s3c24xx-dma.c b/drivers/dma/s3c24xx-dma.c
index a09eeb545f7d..48965baa2fa1 100644
--- a/drivers/dma/s3c24xx-dma.c
+++ b/drivers/dma/s3c24xx-dma.c
@@ -1425,4 +1425,3 @@ EXPORT_SYMBOL(s3c24xx_dma_filter);
 
 MODULE_DESCRIPTION("S3C24XX DMA Driver");
 MODULE_AUTHOR("Heiko Stuebner");
-MODULE_LICENSE("GPL v2");
-- 
2.39.1.268.g9de2f9a303

Re: [PATCH 22/24] kbuild, dmaengine: s3c24xx: remove MODULE_LICENSE in non-modules

[Krzysztof Kozlowski]

On 17/02/2023 15:10, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.

I think you need to base your tree-wide patches on next. The driver was
removed. Please drop the patch.


Best regards,
Krzysztof

Re: [PATCH 00/24] MODULE_LICENSE removals, second tranche

[Will Deacon]

On Fri, 17 Feb 2023 14:10:35 +0000, Nick Alcock wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate.  Due to recent changes to kbuild, these
> uses are now problematic.  See the commit logs for more details.
> 
> (The commit log prefixes and Cc lists are automatically determined using
> the script mentioned below.  I've eyeballed them, and they seem reasonable:
> my apologies if they are not.)
> 
> [...]

Applied drivers/perf patch to will (for-next/perf), thanks!

[08/24] kbuild, drivers/perf: remove MODULE_LICENSE in non-modules
        https://git.kernel.org/will/c/a64021d3726a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev