From: Vinod Koul <vkoul@kernel.org> To: Baolin Wang <baolin.wang@linaro.org> Cc: Dan Williams <dan.j.williams@intel.com>, eric.long@unisoc.com, Orson Zhai <orsonzhai@gmail.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Mark Brown <broonie@kernel.org>, dmaengine@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: [7/7] dmaengine: sprd: Add interrupt support for 2-stage transfer Date: Mon, 29 Apr 2019 19:40:09 +0530 [thread overview] Message-ID: <20190429141009.GO3845@vkoul-mobl.Dlink> (raw) On 29-04-19, 20:11, Baolin Wang wrote: > On Mon, 29 Apr 2019 at 20:01, Vinod Koul <vkoul@kernel.org> wrote: > > On 15-04-19, 20:15, Baolin Wang wrote: > > > @@ -429,6 +433,9 @@ static int sprd_dma_set_2stage_config(struct sprd_dma_chn *schan) > > > val = chn & SPRD_DMA_GLB_SRC_CHN_MASK; > > > val |= BIT(schan->trg_mode - 1) << SPRD_DMA_GLB_TRG_OFFSET; > > > val |= SPRD_DMA_GLB_2STAGE_EN; > > > + if (schan->int_type != SPRD_DMA_NO_INT) > > > > Who configure int_type? > > The int_type is configured through the flags of > sprd_dma_prep_slave_sg() by users, see: > https://elixir.bootlin.com/linux/v5.1-rc6/source/include/linux/dma/sprd-dma.h#L9 Please use DMA_PREP_INTERRUPT flag instead!
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Baolin Wang <baolin.wang@linaro.org> Cc: Dan Williams <dan.j.williams@intel.com>, eric.long@unisoc.com, Orson Zhai <orsonzhai@gmail.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Mark Brown <broonie@kernel.org>, dmaengine@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 7/7] dmaengine: sprd: Add interrupt support for 2-stage transfer Date: Mon, 29 Apr 2019 19:40:09 +0530 [thread overview] Message-ID: <20190429141009.GO3845@vkoul-mobl.Dlink> (raw) Message-ID: <20190429141009.D9Gjtpb2kdJZZnpmAN_ru0fKqTlyjwqj4bFyTv8Y97w@z> (raw) In-Reply-To: <CAMz4kuJB2+6HziyDep4ctfmjFYpmZ-v_vrFQsJ9tHvwYzSJeKA@mail.gmail.com> On 29-04-19, 20:11, Baolin Wang wrote: > On Mon, 29 Apr 2019 at 20:01, Vinod Koul <vkoul@kernel.org> wrote: > > On 15-04-19, 20:15, Baolin Wang wrote: > > > @@ -429,6 +433,9 @@ static int sprd_dma_set_2stage_config(struct sprd_dma_chn *schan) > > > val = chn & SPRD_DMA_GLB_SRC_CHN_MASK; > > > val |= BIT(schan->trg_mode - 1) << SPRD_DMA_GLB_TRG_OFFSET; > > > val |= SPRD_DMA_GLB_2STAGE_EN; > > > + if (schan->int_type != SPRD_DMA_NO_INT) > > > > Who configure int_type? > > The int_type is configured through the flags of > sprd_dma_prep_slave_sg() by users, see: > https://elixir.bootlin.com/linux/v5.1-rc6/source/include/linux/dma/sprd-dma.h#L9 Please use DMA_PREP_INTERRUPT flag instead! -- ~Vinod
next prev reply other threads:[~2019-04-29 14:10 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 12:14 [PATCH 0/7] Fix some bugs and add new feature for Spreadtrum DMA engine Baolin Wang 2019-04-15 12:14 ` [1/7] dmaengine: sprd: Fix the possible crash when getting engine status Baolin Wang 2019-04-15 12:14 ` [PATCH 1/7] " Baolin Wang 2019-04-29 11:35 ` [1/7] " Vinod Koul 2019-04-29 11:35 ` [PATCH 1/7] " Vinod Koul 2019-04-29 11:49 ` [1/7] " Baolin Wang 2019-04-29 11:49 ` [PATCH 1/7] " Baolin Wang 2019-04-29 12:02 ` [1/7] " Vinod Koul 2019-04-29 12:02 ` [PATCH 1/7] " Vinod Koul 2019-04-15 12:14 ` [2/7] dmaengine: sprd: Add validation of current descriptor in irq handler Baolin Wang 2019-04-15 12:14 ` [PATCH 2/7] " Baolin Wang 2019-04-15 12:14 ` [3/7] dmaengine: sprd: Fix the incorrect start for 2-stage destination channels Baolin Wang 2019-04-15 12:14 ` [PATCH 3/7] " Baolin Wang 2019-04-15 12:14 ` [4/7] dmaengine: sprd: Add device validation to support multiple controllers Baolin Wang 2019-04-15 12:14 ` [PATCH 4/7] " Baolin Wang 2019-04-29 11:57 ` [4/7] " Vinod Koul 2019-04-29 11:57 ` [PATCH 4/7] " Vinod Koul 2019-04-29 12:20 ` [4/7] " Baolin Wang 2019-04-29 12:20 ` [PATCH 4/7] " Baolin Wang 2019-04-29 14:05 ` [4/7] " Vinod Koul 2019-04-29 14:05 ` [PATCH 4/7] " Vinod Koul 2019-04-30 5:30 ` [4/7] " Baolin Wang 2019-04-30 5:30 ` [PATCH 4/7] " Baolin Wang 2019-04-30 8:29 ` [4/7] " Vinod Koul 2019-04-30 8:29 ` [PATCH 4/7] " Vinod Koul 2019-04-30 8:34 ` [4/7] " Baolin Wang 2019-04-30 8:34 ` [PATCH 4/7] " Baolin Wang 2019-04-30 8:53 ` [4/7] " Baolin Wang 2019-04-30 8:53 ` [PATCH 4/7] " Baolin Wang 2019-05-02 6:01 ` [4/7] " Vinod Koul 2019-05-02 6:01 ` [PATCH 4/7] " Vinod Koul 2019-05-06 4:48 ` Baolin Wang 2019-04-15 12:14 ` [5/7] dmaengine: sprd: Fix block length overflow Baolin Wang 2019-04-15 12:14 ` [PATCH 5/7] " Baolin Wang 2019-04-15 12:15 ` [6/7] dmaengine: sprd: Fix the right place to configure 2-stage transfer Baolin Wang 2019-04-15 12:15 ` [PATCH 6/7] " Baolin Wang 2019-04-15 12:15 ` [7/7] dmaengine: sprd: Add interrupt support for " Baolin Wang 2019-04-15 12:15 ` [PATCH 7/7] " Baolin Wang 2019-04-29 12:01 ` [7/7] " Vinod Koul 2019-04-29 12:01 ` [PATCH 7/7] " Vinod Koul 2019-04-29 12:11 ` [7/7] " Baolin Wang 2019-04-29 12:11 ` [PATCH 7/7] " Baolin Wang 2019-04-29 14:10 ` Vinod Koul [this message] 2019-04-29 14:10 ` Vinod Koul 2019-04-30 5:37 ` [7/7] " Baolin Wang 2019-04-30 5:37 ` [PATCH 7/7] " Baolin Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190429141009.GO3845@vkoul-mobl.Dlink \ --to=vkoul@kernel.org \ --cc=baolin.wang@linaro.org \ --cc=broonie@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=eric.long@unisoc.com \ --cc=linux-kernel@vger.kernel.org \ --cc=orsonzhai@gmail.com \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).