* [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc_coherent
@ 2019-06-27 17:35 Fuqian Huang
2019-07-01 4:54 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-06-27 17:35 UTC (permalink / raw)
Cc: Fuqian Huang, Dan Williams, Vinod Koul, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
dmaengine, linux-arm-kernel, linux-kernel
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/dma/imx-sdma.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 99d9f431ae2c..54d86359bdf8 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma)
sdma->context_phys = ccb_phys +
MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control);
- /* Zero-out the CCB structures array just allocated */
- memset(sdma->channel_control, 0,
- MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control));
-
/* disable all channels */
for (i = 0; i < sdma->drvdata->num_events; i++)
writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc_coherent
2019-06-27 17:35 [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc_coherent Fuqian Huang
@ 2019-07-01 4:54 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-07-01 4:54 UTC (permalink / raw)
To: Fuqian Huang
Cc: Dan Williams, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, dmaengine, linux-arm-kernel,
linux-kernel
On 28-06-19, 01:35, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
Please point to the exact commit and not the merge commit. Hint use git
blame on that file...
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/dma/imx-sdma.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 99d9f431ae2c..54d86359bdf8 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma)
> sdma->context_phys = ccb_phys +
> MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control);
>
> - /* Zero-out the CCB structures array just allocated */
> - memset(sdma->channel_control, 0,
> - MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control));
> -
> /* disable all channels */
> for (i = 0; i < sdma->drvdata->num_events; i++)
> writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i));
> --
> 2.11.0
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-01 4:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 17:35 [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-07-01 4:54 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).