* [PATCH] dmaengine: ti: omap-dma: Remove variable override in omap_dma_tx_status()
@ 2019-07-30 13:20 Peter Ujfalusi
2019-09-04 4:41 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2019-07-30 13:20 UTC (permalink / raw)
To: vkoul; +Cc: dan.j.williams, dmaengine, linux-arm-kernel, linux-omap
There is no need to fetch local omap_desc since the desc we have is the
correct one already when we need to check the channel status.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/ti/omap-dma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
index 3b57b68df896..9f359ec3386d 100644
--- a/drivers/dma/ti/omap-dma.c
+++ b/drivers/dma/ti/omap-dma.c
@@ -860,7 +860,6 @@ static enum dma_status omap_dma_tx_status(struct dma_chan *chan,
* accordingly and mark it as completed
*/
if (!(ccr & CCR_ENABLE)) {
- struct omap_desc *d = c->desc;
ret = DMA_COMPLETE;
omap_dma_start_desc(c);
vchan_cookie_complete(&d->vd);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: ti: omap-dma: Remove variable override in omap_dma_tx_status()
2019-07-30 13:20 [PATCH] dmaengine: ti: omap-dma: Remove variable override in omap_dma_tx_status() Peter Ujfalusi
@ 2019-09-04 4:41 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-09-04 4:41 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: dan.j.williams, dmaengine, linux-arm-kernel, linux-omap
On 30-07-19, 16:20, Peter Ujfalusi wrote:
> There is no need to fetch local omap_desc since the desc we have is the
> correct one already when we need to check the channel status.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 13:20 [PATCH] dmaengine: ti: omap-dma: Remove variable override in omap_dma_tx_status() Peter Ujfalusi
2019-09-04 4:41 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).