From: Vinod Koul <vkoul@kernel.org> To: Lukas Wunner <lukas@wunner.de> Cc: Mark Brown <broonie@kernel.org>, Stefan Wahren <wahrenst@gmx.net>, linux-spi@vger.kernel.org, dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Eric Anholt <eric@anholt.net>, Nuno Sa <nuno.sa@analog.com>, Martin Sperl <kernel@martin.sperl.org>, Noralf Tronnes <noralf@tronnes.org>, Robert Jarzmik <robert.jarzmik@free.fr>, Florian Kauer <florian.kauer@koalo.de>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com> Subject: Re: [PATCH 08/10] dmaengine: bcm2835: Document struct bcm2835_dmadev Date: Thu, 8 Aug 2019 18:01:37 +0530 Message-ID: <20190808123137.GV12733@vkoul-mobl.Dlink> (raw) In-Reply-To: <f2a812b579c0b99d7fadf61a30a6263a9cc19bc4.1564825752.git.lukas@wunner.de> On 03-08-19, 12:10, Lukas Wunner wrote: > Document the BCM2835 DMA driver's device data structure so that upcoming > commits may add further members with proper kerneldoc. Acked-by: Vinod Koul <vkoul@kernel.org> > > Tested-by: Nuno Sá <nuno.sa@analog.com> > Signed-off-by: Lukas Wunner <lukas@wunner.de> > Cc: Martin Sperl <kernel@martin.sperl.org> > Cc: Florian Kauer <florian.kauer@koalo.de> > --- > drivers/dma/bcm2835-dma.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c > index a65514fcb7f2..14358faf3bff 100644 > --- a/drivers/dma/bcm2835-dma.c > +++ b/drivers/dma/bcm2835-dma.c > @@ -37,6 +37,12 @@ > #define BCM2835_DMA_MAX_DMA_CHAN_SUPPORTED 14 > #define BCM2835_DMA_CHAN_NAME_SIZE 8 > > +/** > + * struct bcm2835_dmadev - BCM2835 DMA controller > + * @ddev: DMA device > + * @base: base address of register map > + * @dma_parms: DMA parameters (to convey 1 GByte max segment size to clients) > + */ > struct bcm2835_dmadev { > struct dma_device ddev; > void __iomem *base; > -- > 2.20.1 -- ~Vinod
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-03 10:10 [PATCH 00/10] Raspberry Pi SPI speedups Lukas Wunner 2019-08-03 10:10 ` [PATCH 01/10] dmaengine: bcm2835: Allow reusable descriptors Lukas Wunner 2019-08-08 12:30 ` Vinod Koul 2019-08-03 10:10 ` [PATCH 04/10] spi: bcm2835: Drop dma_pending flag Lukas Wunner 2019-08-03 10:10 ` [PATCH 05/10] spi: bcm2835: Work around DONE bit erratum Lukas Wunner 2019-08-11 19:45 ` Stefan Wahren 2019-08-11 19:57 ` Lukas Wunner 2019-08-11 20:29 ` Eric Anholt 2019-08-19 19:20 ` Stefan Wahren 2019-08-03 10:10 ` [PATCH 09/10] dmaengine: bcm2835: Avoid accessing memory when copying zeroes Lukas Wunner 2019-08-08 12:31 ` Vinod Koul 2019-08-03 10:10 ` [PATCH 07/10] spi: bcm2835: Speed up TX-only DMA transfers by clearing RX FIFO Lukas Wunner 2019-08-03 10:10 ` [PATCH 06/10] spi: bcm2835: Cache CS register value for ->prepare_message() Lukas Wunner 2019-08-03 10:10 ` [PATCH 02/10] dmaengine: bcm2835: Allow cyclic transactions without interrupt Lukas Wunner 2019-08-08 12:30 ` Vinod Koul 2019-08-03 10:10 ` [PATCH 08/10] dmaengine: bcm2835: Document struct bcm2835_dmadev Lukas Wunner 2019-08-08 12:31 ` Vinod Koul [this message] 2019-08-03 10:10 ` [PATCH 10/10] spi: bcm2835: Speed up RX-only DMA transfers by zero-filling TX FIFO Lukas Wunner 2019-08-03 10:10 ` [PATCH 03/10] spi: Guarantee cacheline alignment of driver-private data Lukas Wunner 2019-09-10 11:29 ` Mark Brown 2019-08-03 16:01 ` [PATCH 00/10] Raspberry Pi SPI speedups Noralf Trønnes 2019-08-11 19:50 ` Stefan Wahren 2019-08-11 19:52 ` Lukas Wunner 2019-08-19 19:22 ` Stefan Wahren 2019-08-21 15:21 ` kernel 2019-08-24 10:33 ` Lukas Wunner 2019-09-07 9:06 ` Lukas Wunner 2019-09-09 16:56 ` Mark Brown 2019-09-10 11:21 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190808123137.GV12733@vkoul-mobl.Dlink \ --to=vkoul@kernel.org \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=broonie@kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=eric@anholt.net \ --cc=f.fainelli@gmail.com \ --cc=florian.kauer@koalo.de \ --cc=kernel@martin.sperl.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=lukas@wunner.de \ --cc=noralf@tronnes.org \ --cc=nuno.sa@analog.com \ --cc=rjui@broadcom.com \ --cc=robert.jarzmik@free.fr \ --cc=sbranden@broadcom.com \ --cc=wahrenst@gmx.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
dmaengine Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \ dmaengine@vger.kernel.org public-inbox-index dmaengine Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine AGPL code for this site: git clone https://public-inbox.org/public-inbox.git