From: Rob Herring <robh@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: vkoul@kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: dmaengine: dma-common: Change dma-channel-mask to uint32-array
Date: Fri, 27 Sep 2019 15:25:39 -0500 [thread overview]
Message-ID: <20190927202539.GA20669@bogus> (raw)
In-Reply-To: <20190926111954.9184-2-peter.ujfalusi@ti.com>
On Thu, Sep 26, 2019 at 02:19:52PM +0300, Peter Ujfalusi wrote:
> Make the dma-channel-mask to be usable for controllers with more than 32
> channels.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Documentation/devicetree/bindings/dma/dma-common.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml b/Documentation/devicetree/bindings/dma/dma-common.yaml
> index ed0a49a6f020..4527f20301ff 100644
> --- a/Documentation/devicetree/bindings/dma/dma-common.yaml
> +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml
> @@ -25,11 +25,18 @@ properties:
> Used to provide DMA controller specific information.
>
> dma-channel-mask:
> - $ref: /schemas/types.yaml#definitions/uint32
> description:
> Bitmask of available DMA channels in ascending order that are
> not reserved by firmware and are available to the
> kernel. i.e. first channel corresponds to LSB.
> + The first item in the array is for channels 0-31, the second is for
> + channels 32-63, etc.
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> + items:
> + minItems: 1
> + # Should be enough
> + maxItems: 255
'items' has to be a separate sub-schema from $ref to have any effect:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32-array
items:
minItems: 1
# Should be enough
maxItems: 255
Or (note the added '-'):
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32-array
- items:
minItems: 1
# Should be enough
maxItems: 255
The first way is my preference.
Rob
next prev parent reply other threads:[~2019-09-27 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 11:19 [PATCH v3 0/3] dmaengine: bindings/edma: dma-channel-mask to array Peter Ujfalusi
2019-09-26 11:19 ` [PATCH v3 1/3] dt-bindings: dmaengine: dma-common: Change dma-channel-mask to uint32-array Peter Ujfalusi
2019-09-27 20:25 ` Rob Herring [this message]
2019-09-26 11:19 ` [PATCH v3 2/3] dt-bindings: dma: ti-edma: Document dma-channel-mask for EDMA Peter Ujfalusi
2019-09-27 20:48 ` Rob Herring
2019-09-30 10:55 ` Peter Ujfalusi
2019-09-26 11:19 ` [PATCH v3 3/3] dmaengine: ti: edma: Add support for handling reserved channels Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927202539.GA20669@bogus \
--to=robh@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).