From: Vinod Koul <vkoul@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller
Date: Mon, 14 Oct 2019 13:58:17 +0530 [thread overview]
Message-ID: <20191014082817.GO2654@vkoul-mobl> (raw)
In-Reply-To: <20190905163726.19690-1-colin.king@canonical.com>
On 05-09-19, 17:37, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array 'handler' on the stack but instead make it
> static const. Makes the object code smaller by 80 bytes.
>
> Before:
> text data bss dec hex filename
> 38225 9084 64 47373 b90d drivers/dma/iop-adma.o
>
> After:
> text data bss dec hex filename
> 38081 9148 64 47293 b8bd drivers/dma/iop-adma.o
>
> (gcc version 9.2.1, amd64)
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-10-14 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:37 [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller Colin King
2019-09-25 20:43 ` Vinod Koul
2019-09-25 20:46 ` Colin Ian King
2019-10-14 8:28 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014082817.GO2654@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).