From: Colin Ian King <colin.king@canonical.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller
Date: Wed, 25 Sep 2019 21:46:48 +0100 [thread overview]
Message-ID: <86c660c4-fccf-4854-188b-c5eefb3e742d@canonical.com> (raw)
In-Reply-To: <20190925204315.GK3824@vkoul-mobl>
On 25/09/2019 21:43, Vinod Koul wrote:
> On 05-09-19, 17:37, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate the array 'handler' on the stack but instead make it
>> static const. Makes the object code smaller by 80 bytes.
>>
>> Before:
>> text data bss dec hex filename
>> 38225 9084 64 47373 b90d drivers/dma/iop-adma.o
>>
>> After:
>> text data bss dec hex filename
>> 38081 9148 64 47293 b8bd drivers/dma/iop-adma.o
>>
>> (gcc version 9.2.1, amd64)
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/dma/iop-adma.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/iop-adma.c b/drivers/dma/iop-adma.c
>> index a3f942a6a946..4dc5478fc156 100644
>> --- a/drivers/dma/iop-adma.c
>> +++ b/drivers/dma/iop-adma.c
>> @@ -1359,9 +1359,11 @@ static int iop_adma_probe(struct platform_device *pdev)
>> iop_adma_device_clear_err_status(iop_chan);
>>
>> for (i = 0; i < 3; i++) {
>> - irq_handler_t handler[] = { iop_adma_eot_handler,
>> - iop_adma_eoc_handler,
>> - iop_adma_err_handler };
>> + static const irq_handler_t handler[] = {
>> + iop_adma_eot_handler,
>> + iop_adma_eoc_handler,
>> + iop_adma_err_handler
>
> would it not be more apt to declare the handler outside the loop!
Originally yes, but now it's static, no.
>
>> + };
>> int irq = platform_get_irq(pdev, i);
>> if (irq < 0) {
>> ret = -ENXIO;
>> --
>> 2.20.1
>
next prev parent reply other threads:[~2019-09-25 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:37 [PATCH] dmaengine: iop-adma: make array 'handler' static const, makes object smaller Colin King
2019-09-25 20:43 ` Vinod Koul
2019-09-25 20:46 ` Colin Ian King [this message]
2019-10-14 8:28 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86c660c4-fccf-4854-188b-c5eefb3e742d@canonical.com \
--to=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).