* [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log
@ 2019-11-06 16:31 Vinod Koul
2019-11-06 16:31 ` [PATCH 2/2] dmaengine: milbeaut-xdmac: " Vinod Koul
2019-11-08 3:56 ` [PATCH 1/2] dmaengine: milbeaut-hdmac: " Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Vinod Koul @ 2019-11-06 16:31 UTC (permalink / raw)
To: dmaengine; +Cc: jaswinder.singh, Vinod Koul, kbuild test robot
platform_get_irq() prints the error message, so caller need not do so,
remove the error line in this driver for platform_get_irq()
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/milbeaut-hdmac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/milbeaut-hdmac.c b/drivers/dma/milbeaut-hdmac.c
index 2bb33535ab9e..8853d442430b 100644
--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -431,11 +431,8 @@ static int milbeaut_hdmac_chan_init(struct platform_device *pdev,
int irq, ret;
irq = platform_get_irq(pdev, chan_id);
- if (irq < 0) {
- dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n",
- chan_id);
+ if (irq < 0)
return irq;
- }
irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-hdmac-%d",
chan_id);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] dmaengine: milbeaut-xdmac: remove redundant error log
2019-11-06 16:31 [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log Vinod Koul
@ 2019-11-06 16:31 ` Vinod Koul
2019-11-08 3:56 ` [PATCH 1/2] dmaengine: milbeaut-hdmac: " Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-11-06 16:31 UTC (permalink / raw)
To: dmaengine; +Cc: jaswinder.singh, Vinod Koul, kbuild test robot
platform_get_irq() prints the error message, so caller need not do so,
remove the error line in this driver for platform_get_irq()
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/milbeaut-xdmac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/milbeaut-xdmac.c b/drivers/dma/milbeaut-xdmac.c
index 3d5b1926a58d..ab3d2f395378 100644
--- a/drivers/dma/milbeaut-xdmac.c
+++ b/drivers/dma/milbeaut-xdmac.c
@@ -269,11 +269,8 @@ static int milbeaut_xdmac_chan_init(struct platform_device *pdev,
int irq, ret;
irq = platform_get_irq(pdev, chan_id);
- if (irq < 0) {
- dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n",
- chan_id);
+ if (irq < 0)
return irq;
- }
irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-xdmac-%d",
chan_id);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log
2019-11-06 16:31 [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log Vinod Koul
2019-11-06 16:31 ` [PATCH 2/2] dmaengine: milbeaut-xdmac: " Vinod Koul
@ 2019-11-08 3:56 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-11-08 3:56 UTC (permalink / raw)
To: dmaengine; +Cc: jaswinder.singh, kbuild test robot
On 06-11-19, 22:01, Vinod Koul wrote:
> platform_get_irq() prints the error message, so caller need not do so,
> remove the error line in this driver for platform_get_irq()
Applied these now
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-08 3:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 16:31 [PATCH 1/2] dmaengine: milbeaut-hdmac: remove redundant error log Vinod Koul
2019-11-06 16:31 ` [PATCH 2/2] dmaengine: milbeaut-xdmac: " Vinod Koul
2019-11-08 3:56 ` [PATCH 1/2] dmaengine: milbeaut-hdmac: " Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).