dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment
@ 2019-11-18 14:35 Green Wan
  2019-11-18 14:35 ` [PATCH 2/2] dmaengine: sf-pdma: move macro to header file Green Wan
  2019-11-22  5:45 ` [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Green Wan @ 2019-11-18 14:35 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Green Wan, Dan Williams, Vinod Koul, dmaengine, linux-kernel

There are several comments starting from "/**" but not for function
comment purpose. It causes kernel-doc parsing wrong string. Replace
"/**" with "/*" to fix them.

Signed-off-by: Green Wan <green.wan@sifive.com>
---
 drivers/dma/sf-pdma/sf-pdma.c | 2 +-
 drivers/dma/sf-pdma/sf-pdma.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index 16fe00553496..e8b9770dcfba 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
-/**
+/*
  * SiFive FU540 Platform DMA driver
  * Copyright (C) 2019 SiFive
  *
diff --git a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h
index 55816c9e0249..aab65a0bdfcc 100644
--- a/drivers/dma/sf-pdma/sf-pdma.h
+++ b/drivers/dma/sf-pdma/sf-pdma.h
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0-or-later */
-/**
+/*
  * SiFive FU540 Platform DMA driver
  * Copyright (C) 2019 SiFive
  *

base-commit: a7e335deed174a37fc6f84f69caaeff8a08f8ff8
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] dmaengine: sf-pdma: move macro to header file
  2019-11-18 14:35 [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Green Wan
@ 2019-11-18 14:35 ` Green Wan
  2019-11-22  5:45 ` [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Green Wan @ 2019-11-18 14:35 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Green Wan, Dan Williams, Vinod Koul, dmaengine, linux-kernel

The place where the macro, SF_PDMA_REG_BASE(), is cause kernel-doc
using wrong function declaration. Move it to header file.

Signed-off-by: Green Wan <green.wan@sifive.com>
---
 drivers/dma/sf-pdma/sf-pdma.c | 1 -
 drivers/dma/sf-pdma/sf-pdma.h | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index e8b9770dcfba..465256fe8b1f 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -435,7 +435,6 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
  *
  * Return: none
  */
-#define SF_PDMA_REG_BASE(ch)	(pdma->membase + (PDMA_CHAN_OFFSET * (ch)))
 static void sf_pdma_setup_chans(struct sf_pdma *pdma)
 {
 	int i;
diff --git a/drivers/dma/sf-pdma/sf-pdma.h b/drivers/dma/sf-pdma/sf-pdma.h
index aab65a0bdfcc..0c20167b097d 100644
--- a/drivers/dma/sf-pdma/sf-pdma.h
+++ b/drivers/dma/sf-pdma/sf-pdma.h
@@ -57,6 +57,8 @@
 /* Error Recovery */
 #define MAX_RETRY					1
 
+#define SF_PDMA_REG_BASE(ch)	(pdma->membase + (PDMA_CHAN_OFFSET * (ch)))
+
 struct pdma_regs {
 	/* read-write regs */
 	void __iomem *ctrl;		/* 4 bytes */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment
  2019-11-18 14:35 [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Green Wan
  2019-11-18 14:35 ` [PATCH 2/2] dmaengine: sf-pdma: move macro to header file Green Wan
@ 2019-11-22  5:45 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-11-22  5:45 UTC (permalink / raw)
  To: Green Wan; +Cc: Dan Williams, dmaengine, linux-kernel

On 18-11-19, 22:35, Green Wan wrote:
> There are several comments starting from "/**" but not for function
> comment purpose. It causes kernel-doc parsing wrong string. Replace
> "/**" with "/*" to fix them.

Applied both, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-18 14:35 [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Green Wan
2019-11-18 14:35 ` [PATCH 2/2] dmaengine: sf-pdma: move macro to header file Green Wan
2019-11-22  5:45 ` [PATCH 1/2] dmaengine: sf-pdma: replace /** with /* for non-function comment Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git