dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free
@ 2019-11-15  8:31 Chuhong Yuan
  2019-11-22  5:22 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-15  8:31 UTC (permalink / raw)
  To: unlisted-recipients:; (no To-header on input)
  Cc: Dan Williams, Vinod Koul, dmaengine, linux-kernel, Chuhong Yuan

The driver calls of_dma_controller_register in probe but does not free
it in remove.
Add the call to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 drivers/dma/mmp_tdma.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index e7d1e12bf464..10117f271b12 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -544,6 +544,9 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)
 
 static int mmp_tdma_remove(struct platform_device *pdev)
 {
+	if (pdev->dev.of_node)
+		of_dma_controller_free(pdev->dev.of_node);
+
 	return 0;
 }
 
-- 
2.24.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free
  2019-11-15  8:31 [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free Chuhong Yuan
@ 2019-11-22  5:22 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2019-11-22  5:22 UTC (permalink / raw)
  To: Chuhong Yuan; +Cc: Dan Williams, dmaengine, linux-kernel

On 15-11-19, 16:31, Chuhong Yuan wrote:
> The driver calls of_dma_controller_register in probe but does not free
> it in remove.
> Add the call to fix it.

Applied both, thanks.

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15  8:31 [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free Chuhong Yuan
2019-11-22  5:22 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git