From: Vinod Koul <vkoul@kernel.org>
To: Zhou Wang <wangzhou1@hisilicon.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linuxarm@huawei.com,
Zhenfa Qiu <qiuzhenfa@hisilicon.com>
Subject: Re: [PATCH v2] dmaengine: hisilicon: Add Kunpeng DMA engine support
Date: Wed, 11 Dec 2019 22:24:58 +0530 [thread overview]
Message-ID: <20191211165458.GJ2536@vkoul-mobl> (raw)
In-Reply-To: <5DF0D666.6060908@hisilicon.com>
On 11-12-19, 19:43, Zhou Wang wrote:
> On 2019/12/11 18:52, Vinod Koul wrote:
> > On 10-12-19, 10:13, Zhou Wang wrote:
> >> +static int hisi_dma_terminate_all(struct dma_chan *c)
> >> +{
> >> + struct hisi_dma_chan *chan = to_hisi_dma_chan(c);
> >> + unsigned long flags;
> >> + LIST_HEAD(head);
> >> +
> >> + spin_lock_irqsave(&chan->vc.lock, flags);
> >> +
> >> + hisi_dma_pause_dma(chan->hdma_dev, chan->qp_num, true);
> >> + if (chan->desc) {
> >> + vchan_terminate_vdesc(&chan->desc->vd);
> >> + chan->desc = NULL;
> >> + }
> >> +
> >> + vchan_get_all_descriptors(&chan->vc, &head);
> >> +
> >> + spin_unlock_irqrestore(&chan->vc.lock, flags);
> >> +
> >> + vchan_dma_desc_free_list(&chan->vc, &head);
> >> + hisi_dma_pause_dma(chan->hdma_dev, chan->qp_num, false);
> >
> > pause on terminate? Not DISABLE?
>
> here this function just aborts transfers on specific channel.
yeah and I would expect the channel to go into disable state right!
> >> +static struct pci_driver hisi_dma_pci_driver = {
> >> + .name = "hisi_dma",
> >> + .id_table = hisi_dma_pci_tbl,
> >> + .probe = hisi_dma_probe,
> >
> > no .remove and kconfig has a tristate option!
>
> Use devres APIs in probe, so seems nothing should be done in remove :)
who will de-register from dmaengine, you have dangiling chan_tasklet
which needs to be killed and you have isr which is still enabled, yeah
what could go wrong!
Please, deregister from dmaengine, kill the vchan tasklet and make sur
irq is disabled and tasklets killed
--
~Vinod
next prev parent reply other threads:[~2019-12-11 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 2:13 [PATCH v2] dmaengine: hisilicon: Add Kunpeng DMA engine support Zhou Wang
2019-12-11 10:52 ` Vinod Koul
2019-12-11 11:43 ` Zhou Wang
2019-12-11 16:54 ` Vinod Koul [this message]
2019-12-27 4:16 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211165458.GJ2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=qiuzhenfa@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).