From: Zhou Wang <wangzhou1@hisilicon.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>, <linuxarm@huawei.com>,
Zhenfa Qiu <qiuzhenfa@hisilicon.com>
Subject: Re: [PATCH v2] dmaengine: hisilicon: Add Kunpeng DMA engine support
Date: Wed, 11 Dec 2019 19:43:34 +0800 [thread overview]
Message-ID: <5DF0D666.6060908@hisilicon.com> (raw)
In-Reply-To: <20191211105234.GG2536@vkoul-mobl>
On 2019/12/11 18:52, Vinod Koul wrote:
> On 10-12-19, 10:13, Zhou Wang wrote:
>> This patch adds a driver for HiSilicon Kunpeng DMA engine.
>
> Can you please describe this controller here, how many channels,
> controller capabilities etc
OK, will add related description about this controller.
>
>> +static void hisi_dma_enable_dma(struct hisi_dma_dev *hdma_dev, u32 index,
>> + bool enable)
>
> Coding Style expects the second line to be aligned to preceding line
> brace opne, --strict option with checkpatch should warn you!
seems code it right, just looks wrong in patch. However, I checked
whole patch again with --strict, find some other warnings, will fix them
in next version.
>
>> +{
>> + void __iomem *addr = hdma_dev->base + HISI_DMA_CTRL0(index);
>> + u32 tmp;
>> +
>> + tmp = readl_relaxed(addr);
>> + tmp = enable ? tmp | HISI_DMA_CTRL0_QUEUE_EN :
>> + tmp & ~HISI_DMA_CTRL0_QUEUE_EN;
>> + writel_relaxed(tmp, addr);
>> +}
>
> why not create a modifyl() macro and then use that here and other places
> rather than doiun read, modify, write sequence
OK.
>
>> +static void hisi_dma_reset_hw_chan(struct hisi_dma_chan *chan)
>> +{
>> + struct hisi_dma_dev *hdma_dev = chan->hdma_dev;
>> + u32 index = chan->qp_num, tmp;
>> + int ret;
>> +
>> + hisi_dma_pause_dma(hdma_dev, index, true);
>> + hisi_dma_enable_dma(hdma_dev, index, false);
>> + hisi_dma_mask_irq(hdma_dev, index);
>> +
>> + ret = readl_relaxed_poll_timeout(hdma_dev->base +
>> + HISI_DMA_Q_FSM_STS(index), tmp,
>> + FIELD_GET(HISI_DMA_FSM_STS_MASK, tmp) != RUN, 10, 1000);
>> + if (ret)
>> + dev_err(&hdma_dev->pdev->dev, "disable channel timeout!\n");
>
> you want to continue on this timeout?
need find a way to handle this, thanks.
>
>> +static int hisi_dma_terminate_all(struct dma_chan *c)
>> +{
>> + struct hisi_dma_chan *chan = to_hisi_dma_chan(c);
>> + unsigned long flags;
>> + LIST_HEAD(head);
>> +
>> + spin_lock_irqsave(&chan->vc.lock, flags);
>> +
>> + hisi_dma_pause_dma(chan->hdma_dev, chan->qp_num, true);
>> + if (chan->desc) {
>> + vchan_terminate_vdesc(&chan->desc->vd);
>> + chan->desc = NULL;
>> + }
>> +
>> + vchan_get_all_descriptors(&chan->vc, &head);
>> +
>> + spin_unlock_irqrestore(&chan->vc.lock, flags);
>> +
>> + vchan_dma_desc_free_list(&chan->vc, &head);
>> + hisi_dma_pause_dma(chan->hdma_dev, chan->qp_num, false);
>
> pause on terminate? Not DISABLE?
here this function just aborts transfers on specific channel.
>
>> +static struct pci_driver hisi_dma_pci_driver = {
>> + .name = "hisi_dma",
>> + .id_table = hisi_dma_pci_tbl,
>> + .probe = hisi_dma_probe,
>
> no .remove and kconfig has a tristate option!
Use devres APIs in probe, so seems nothing should be done in remove :)
Best,
Zhou
>
>> +MODULE_AUTHOR("Zhou Wang <wangzhou1@hisilicon.com>");
>> +MODULE_AUTHOR("Zhenfa Qiu <qiuzhenfa@hisilicon.com>");
>> +MODULE_DESCRIPTION("HiSilicon Kunpeng DMA controller driver");
>> +MODULE_LICENSE("GPL");
>
> GPL v2..
>
next prev parent reply other threads:[~2019-12-11 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 2:13 [PATCH v2] dmaengine: hisilicon: Add Kunpeng DMA engine support Zhou Wang
2019-12-11 10:52 ` Vinod Koul
2019-12-11 11:43 ` Zhou Wang [this message]
2019-12-11 16:54 ` Vinod Koul
2019-12-27 4:16 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DF0D666.6060908@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=qiuzhenfa@hisilicon.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).