* [PATCH] dmaengine: move .device_release missing log warning to debug level
@ 2020-03-06 13:50 Vinod Koul
2020-03-11 9:13 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2020-03-06 13:50 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul
Dmaengine core warns the drivers registering for missing .device_release
implementation. The warning is accurate for dmaengine controllers which
hotplug but not for rest.
So reduce this to a debug log.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index c3b1283b6d31..17909fd1820f 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -1151,7 +1151,7 @@ int dma_async_device_register(struct dma_device *device)
}
if (!device->device_release)
- dev_warn(device->dev,
+ dev_dbg(device->dev,
"WARN: Device release is not defined so it is not safe to unbind this driver while in use\n");
kref_init(&device->ref);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: move .device_release missing log warning to debug level
2020-03-06 13:50 [PATCH] dmaengine: move .device_release missing log warning to debug level Vinod Koul
@ 2020-03-11 9:13 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-03-11 9:13 UTC (permalink / raw)
To: dmaengine
On 06-03-20, 19:20, Vinod Koul wrote:
> Dmaengine core warns the drivers registering for missing .device_release
> implementation. The warning is accurate for dmaengine controllers which
> hotplug but not for rest.
>
> So reduce this to a debug log.
Applied now
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 13:50 [PATCH] dmaengine: move .device_release missing log warning to debug level Vinod Koul
2020-03-11 9:13 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).