From: Rob Herring <robh@kernel.org>
To: Sergey.Semin@baikalelectronics.ru
Cc: Vinod Koul <vkoul@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings
Date: Thu, 12 Mar 2020 16:33:30 -0500 [thread overview]
Message-ID: <20200312213330.GA30463@bogus> (raw)
In-Reply-To: <20200306131049.37EDD8030708@mail.baikalelectronics.ru>
On Fri, Mar 06, 2020 at 04:10:31PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> This array property is used to indicate the maximum burst transaction
> length supported by each DMA channel.
>
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Paul Burton <paulburton@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> .../devicetree/bindings/dma/snps,dma-spear1340.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> index d7f9383ceb8f..308ec6482064 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dma-spear1340.yaml
> @@ -126,6 +126,18 @@ properties:
> enum: [0, 1]
> default: 0
>
> + snps,max-burst-len:
> + description: |
> + Maximum length of burst transactions supported by hardware.
> + It's an array property with one cell per channel in units of
> + CTLx register SRC_TR_WIDTH/DST_TR_WIDTH field.
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32-array
> + - maxItems: 8
> + items:
> + enum: [4, 8, 16, 32, 64, 128, 256]
> + default: 0
The default needs to be an allowed value in the enum.
Rob
next prev parent reply other threads:[~2020-03-12 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306131035.10937-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:10 ` [PATCH 2/5] dt-bindings: dma: dw: Add max burst transaction length property bindings Sergey.Semin
2020-03-12 21:33 ` Rob Herring [this message]
2020-04-11 18:21 ` Sergey Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312213330.GA30463@bogus \
--to=robh@kernel.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).