dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
@ 2020-03-20  7:13 YueHaibing
  2020-03-20 14:25 ` Dmitry Osipenko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2020-03-20  7:13 UTC (permalink / raw)
  To: ldewangan, jonathanh, dan.j.williams, vkoul, thierry.reding, swarren
  Cc: dmaengine, linux-tegra, linux-kernel, digetx, YueHaibing

When CONFIG_PM is disabled, gcc warning this:

drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]

Make it as __maybe_unused to fix the warnings,
also remove unneeded function declarations.

Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/dma/tegra20-apb-dma.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 4e295d121be6..b33000976f66 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -263,8 +263,6 @@ static inline struct device *tdc2dev(struct tegra_dma_channel *tdc)
 }
 
 static dma_cookie_t tegra_dma_tx_submit(struct dma_async_tx_descriptor *tx);
-static int tegra_dma_runtime_suspend(struct device *dev);
-static int tegra_dma_runtime_resume(struct device *dev);
 
 /* Get DMA desc from free list, if not there then allocate it.  */
 static struct tegra_dma_desc *tegra_dma_desc_get(struct tegra_dma_channel *tdc)
@@ -1575,7 +1573,7 @@ static int tegra_dma_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static int tegra_dma_runtime_suspend(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_suspend(struct device *dev)
 {
 	struct tegra_dma *tdma = dev_get_drvdata(dev);
 
@@ -1584,7 +1582,7 @@ static int tegra_dma_runtime_suspend(struct device *dev)
 	return 0;
 }
 
-static int tegra_dma_runtime_resume(struct device *dev)
+static int __maybe_unused tegra_dma_runtime_resume(struct device *dev)
 {
 	struct tegra_dma *tdma = dev_get_drvdata(dev);
 
-- 
2.17.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
  2020-03-20  7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
@ 2020-03-20 14:25 ` Dmitry Osipenko
  2020-03-20 15:11 ` Thierry Reding
  2020-03-23  6:30 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Osipenko @ 2020-03-20 14:25 UTC (permalink / raw)
  To: YueHaibing, ldewangan, jonathanh, dan.j.williams, vkoul,
	thierry.reding, swarren
  Cc: dmaengine, linux-tegra, linux-kernel

20.03.2020 10:13, YueHaibing пишет:
> When CONFIG_PM is disabled, gcc warning this:
> 
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
> 
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
> 
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
...

Looks good, thank you:

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
  2020-03-20  7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
  2020-03-20 14:25 ` Dmitry Osipenko
@ 2020-03-20 15:11 ` Thierry Reding
  2020-03-23  6:30 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2020-03-20 15:11 UTC (permalink / raw)
  To: YueHaibing
  Cc: ldewangan, jonathanh, dan.j.williams, vkoul, swarren, dmaengine,
	linux-tegra, linux-kernel, digetx

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
> 
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
> 
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
> 
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/dma/tegra20-apb-dma.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
  2020-03-20  7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
  2020-03-20 14:25 ` Dmitry Osipenko
  2020-03-20 15:11 ` Thierry Reding
@ 2020-03-23  6:30 ` Vinod Koul
  2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-03-23  6:30 UTC (permalink / raw)
  To: YueHaibing
  Cc: ldewangan, jonathanh, dan.j.williams, thierry.reding, swarren,
	dmaengine, linux-tegra, linux-kernel, digetx

On 20-03-20, 15:13, YueHaibing wrote:
> When CONFIG_PM is disabled, gcc warning this:
> 
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
> 
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20  7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
2020-03-20 14:25 ` Dmitry Osipenko
2020-03-20 15:11 ` Thierry Reding
2020-03-23  6:30 ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git