* [PATCH -next] dmaengine: moxart-dma: Drop pointless static qualifier in moxart_probe()
@ 2020-05-05 10:13 YueHaibing
2020-05-13 12:03 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-05-05 10:13 UTC (permalink / raw)
To: Vinod Koul, Dan Williams; +Cc: YueHaibing, dmaengine, kernel-janitors
There is no need to have the 'void __iomem *dma_base_addr' variable
static since new value always be assigned before use it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/dma/moxart-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index 2a77fa319d78..347146a6e1d0 100644
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -568,7 +568,7 @@ static int moxart_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct device_node *node = dev->of_node;
struct resource *res;
- static void __iomem *dma_base_addr;
+ void __iomem *dma_base_addr;
int ret, i;
unsigned int irq;
struct moxart_chan *ch;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] dmaengine: moxart-dma: Drop pointless static qualifier in moxart_probe()
2020-05-05 10:13 [PATCH -next] dmaengine: moxart-dma: Drop pointless static qualifier in moxart_probe() YueHaibing
@ 2020-05-13 12:03 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-05-13 12:03 UTC (permalink / raw)
To: YueHaibing; +Cc: Dan Williams, dmaengine, kernel-janitors
On 05-05-20, 10:13, YueHaibing wrote:
> There is no need to have the 'void __iomem *dma_base_addr' variable
> static since new value always be assigned before use it.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 12:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 10:13 [PATCH -next] dmaengine: moxart-dma: Drop pointless static qualifier in moxart_probe() YueHaibing
2020-05-13 12:03 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).