* [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans
@ 2020-06-01 19:23 Lubomir Rintel
2020-06-16 16:28 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Lubomir Rintel @ 2020-06-01 19:23 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, dmaengine, linux-kernel, Lubomir Rintel
When there's a single interrupt for all the DMA channels, the
unsuccessful attempt to request separate IRQs emits useless warnings:
[ 1.370381] mmp-pdma d4000000.dma: IRQ index 1 not found
...
[ 1.412398] mmp-pdma d4000000.dma: IRQ index 15 not found
[ 1.418308] mmp-pdma d4000000.dma: initialized 16 channels
Avoid that, treating the IRQs as optional.
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/dma/mmp_pdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index ad06f260e907d..41c542eaa23a5 100644
--- a/drivers/dma/mmp_pdma.c
+++ b/drivers/dma/mmp_pdma.c
@@ -1060,7 +1060,7 @@ static int mmp_pdma_probe(struct platform_device *op)
pdev->dma_channels = dma_channels;
for (i = 0; i < dma_channels; i++) {
- if (platform_get_irq(op, i) > 0)
+ if (platform_get_irq_optional(op, i) > 0)
irq_num++;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans
2020-06-01 19:23 [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans Lubomir Rintel
@ 2020-06-16 16:28 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-06-16 16:28 UTC (permalink / raw)
To: Lubomir Rintel; +Cc: Dan Williams, dmaengine, linux-kernel
On 01-06-20, 21:23, Lubomir Rintel wrote:
> When there's a single interrupt for all the DMA channels, the
> unsuccessful attempt to request separate IRQs emits useless warnings:
>
> [ 1.370381] mmp-pdma d4000000.dma: IRQ index 1 not found
> ...
> [ 1.412398] mmp-pdma d4000000.dma: IRQ index 15 not found
> [ 1.418308] mmp-pdma d4000000.dma: initialized 16 channels
>
> Avoid that, treating the IRQs as optional.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01 19:23 [RESEND PATCH] dmaengine: mmp_pdma: Do not warn when IRQ is shared by all chans Lubomir Rintel
2020-06-16 16:28 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).