dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 06/15] dmaengine: dw-edma: use PCI_IRQ_MSI_TYPES  where appropriate
@ 2020-06-02  9:20 Piotr Stankiewicz
  2020-06-16 16:31 ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02  9:20 UTC (permalink / raw)
  To: Gustavo Pimentel, Dan Williams, Vinod Koul
  Cc: dmaengine, linux-kernel, Piotr Stankiewicz

Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.

Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
 drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
index dc85f55e1bb8..46defe30ac25 100644
--- a/drivers/dma/dw-edma/dw-edma-pcie.c
+++ b/drivers/dma/dw-edma/dw-edma-pcie.c
@@ -117,7 +117,7 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
 
 	/* IRQs allocation */
 	nr_irqs = pci_alloc_irq_vectors(pdev, 1, pdata->irqs,
-					PCI_IRQ_MSI | PCI_IRQ_MSIX);
+					PCI_IRQ_MSI_TYPES);
 	if (nr_irqs < 1) {
 		pci_err(pdev, "fail to alloc IRQ vector (number of IRQs=%u)\n",
 			nr_irqs);
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 06/15] dmaengine: dw-edma: use PCI_IRQ_MSI_TYPES  where appropriate
  2020-06-02  9:20 [PATCH 06/15] dmaengine: dw-edma: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-16 16:31 ` Vinod Koul
  2020-06-16 18:11   ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2020-06-16 16:31 UTC (permalink / raw)
  To: Piotr Stankiewicz; +Cc: Gustavo Pimentel, Dan Williams, dmaengine, linux-kernel

On 02-06-20, 11:20, Piotr Stankiewicz wrote:
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 06/15] dmaengine: dw-edma: use PCI_IRQ_MSI_TYPES  where appropriate
  2020-06-16 16:31 ` Vinod Koul
@ 2020-06-16 18:11   ` Vinod Koul
  0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-06-16 18:11 UTC (permalink / raw)
  To: Piotr Stankiewicz; +Cc: Gustavo Pimentel, Dan Williams, dmaengine, linux-kernel

On 16-06-20, 22:01, Vinod Koul wrote:
> On 02-06-20, 11:20, Piotr Stankiewicz wrote:
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
> 
> Applied, thanks

Dropped now.. PCI_IRQ_MSI_TYPES is not upstream yet!

Feel free to take in PCI tree with my ack

Acked-By: Vinod Koul <vkoul@kernel.org>

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02  9:20 [PATCH 06/15] dmaengine: dw-edma: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-16 16:31 ` Vinod Koul
2020-06-16 18:11   ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git