[PATCH] dmaengine: idxd: fix misc interrupt handler thread unmasking

[PATCH] dmaengine: idxd: fix misc interrupt handler thread unmasking

[Dave Jiang]

Fix unmasking of misc interrupt handler when completing normal. It exits
early and skips the unmasking with the current implementation. Fix to
unmask interrupt when exiting normally.

Fixes: bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data accelerators")

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/irq.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index 6052765ca3c8..b7db8a0e1773 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -135,7 +135,7 @@ irqreturn_t idxd_misc_thread(int vec, void *data)
 
 	iowrite32(cause, idxd->reg_base + IDXD_INTCAUSE_OFFSET);
 	if (!err)
-		return IRQ_HANDLED;
+		goto out;
 
 	gensts.bits = ioread32(idxd->reg_base + IDXD_GENSTATS_OFFSET);
 	if (gensts.state == IDXD_DEVICE_STATE_HALT) {
@@ -159,6 +159,7 @@ irqreturn_t idxd_misc_thread(int vec, void *data)
 		}
 	}
 
+ out:
 	idxd_unmask_msix_vector(idxd, irq_entry->id);
 	return IRQ_HANDLED;
 }

Re: [PATCH] dmaengine: idxd: fix misc interrupt handler thread unmasking

[Vinod Koul]

On 18-06-20, 15:07, Dave Jiang wrote:
> Fix unmasking of misc interrupt handler when completing normal. It exits
> early and skips the unmasking with the current implementation. Fix to
> unmask interrupt when exiting normally.
> 
> Fixes: bfe1d56091c1 ("dmaengine: idxd: Init and probe for Intel data accelerators")
> 

ugh!

> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

Anyway this fails to apply, please rebase on fixes and resend

Thanks
-- 
~Vinod