dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Allen Pais <allen.lkml@gmail.com>
To: vkoul@kernel.org
Cc: linus.walleij@linaro.org, vireshk@kernel.org, leoyang.li@nxp.com,
	zw@zh-kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	sean.wang@mediatek.com, matthias.bgg@gmail.com,
	logang@deltatee.com, agross@kernel.org,
	jorn.andersson@linaro.org, green.wan@sifive.com,
	baohua@kernel.org, mripard@kernel.org, wens@csie.org,
	dmaengine@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
	Romain Perier <romain.perier@gmail.com>
Subject: [PATCH v3 22/35] dmaengine: qcom: convert tasklets to use new tasklet_setup() API
Date: Mon, 31 Aug 2020 16:05:29 +0530	[thread overview]
Message-ID: <20200831103542.305571-23-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200831103542.305571-1-allen.lkml@gmail.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/dma/qcom/bam_dma.c  | 6 +++---
 drivers/dma/qcom/hidma.c    | 6 +++---
 drivers/dma/qcom/hidma_ll.c | 6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index 5a08dd0d3388..8ba7a8f089c8 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c
@@ -1075,9 +1075,9 @@ static void bam_start_dma(struct bam_chan *bchan)
  *
  * Sets up next DMA operation and then processes all completed transactions
  */
-static void dma_tasklet(unsigned long data)
+static void dma_tasklet(struct tasklet_struct *t)
 {
-	struct bam_device *bdev = (struct bam_device *)data;
+	struct bam_device *bdev = from_tasklet(bdev, t, task);
 	struct bam_chan *bchan;
 	unsigned long flags;
 	unsigned int i;
@@ -1293,7 +1293,7 @@ static int bam_dma_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_disable_clk;
 
-	tasklet_init(&bdev->task, dma_tasklet, (unsigned long)bdev);
+	tasklet_setup(&bdev->task, dma_tasklet);
 
 	bdev->channels = devm_kcalloc(bdev->dev, bdev->num_channels,
 				sizeof(*bdev->channels), GFP_KERNEL);
diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
index 0a6d3ea08c78..6c0f9eb8ecc6 100644
--- a/drivers/dma/qcom/hidma.c
+++ b/drivers/dma/qcom/hidma.c
@@ -224,9 +224,9 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig)
 	return 0;
 }
 
-static void hidma_issue_task(unsigned long arg)
+static void hidma_issue_task(struct tasklet_struct *t)
 {
-	struct hidma_dev *dmadev = (struct hidma_dev *)arg;
+	struct hidma_dev *dmadev = from_tasklet(dmadev, t, task);
 
 	pm_runtime_get_sync(dmadev->ddev.dev);
 	hidma_ll_start(dmadev->lldev);
@@ -885,7 +885,7 @@ static int hidma_probe(struct platform_device *pdev)
 		goto uninit;
 
 	dmadev->irq = chirq;
-	tasklet_init(&dmadev->task, hidma_issue_task, (unsigned long)dmadev);
+	tasklet_setup(&dmadev->task, hidma_issue_task);
 	hidma_debug_init(dmadev);
 	hidma_sysfs_init(dmadev);
 	dev_info(&pdev->dev, "HI-DMA engine driver registration complete\n");
diff --git a/drivers/dma/qcom/hidma_ll.c b/drivers/dma/qcom/hidma_ll.c
index bb4471e84e48..53244e0e34a3 100644
--- a/drivers/dma/qcom/hidma_ll.c
+++ b/drivers/dma/qcom/hidma_ll.c
@@ -173,9 +173,9 @@ int hidma_ll_request(struct hidma_lldev *lldev, u32 sig, const char *dev_name,
 /*
  * Multiple TREs may be queued and waiting in the pending queue.
  */
-static void hidma_ll_tre_complete(unsigned long arg)
+static void hidma_ll_tre_complete(struct tasklet_struct *t)
 {
-	struct hidma_lldev *lldev = (struct hidma_lldev *)arg;
+	struct hidma_lldev *lldev = from_tasklet(lldev, t, task);
 	struct hidma_tre *tre;
 
 	while (kfifo_out(&lldev->handoff_fifo, &tre, 1)) {
@@ -792,7 +792,7 @@ struct hidma_lldev *hidma_ll_init(struct device *dev, u32 nr_tres,
 		return NULL;
 
 	spin_lock_init(&lldev->lock);
-	tasklet_init(&lldev->task, hidma_ll_tre_complete, (unsigned long)lldev);
+	tasklet_setup(&lldev->task, hidma_ll_tre_complete);
 	lldev->initialized = 1;
 	writel(ENABLE_IRQS, lldev->evca + HIDMA_EVCA_IRQ_EN_REG);
 	return lldev;
-- 
2.25.1


  parent reply	other threads:[~2020-08-31 10:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 10:35 [PATCH v3 00/35] dmaengine: convert tasklets to use new Allen Pais
2020-08-31 10:35 ` [PATCH v3 01/35] dmaengine: altera-msgdma: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-31 10:35 ` [PATCH v3 02/35] dmaengine: at_hdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 03/35] dmaengine: at_xdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 04/35] dmaengine: coh901318: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 05/35] dmaengine: dw: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 06/35] dmaengine: ep93xx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 07/35] dmaengine: fsl: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 08/35] dmaengine: imx-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 09/35] dmaengine: ioat: " Allen Pais
2020-08-31 14:47   ` Dave Jiang
2020-08-31 10:35 ` [PATCH v3 10/35] dmaengine: iop_adma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 11/35] dmaengine: ipu: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 12/35] dmaengine: k3dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 13/35] dmaengine: mediatek: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 14/35] dmaengine: mmp: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 15/35] dmaengine: mpc512x: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 16/35] dmaengine: mv_xor: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 17/35] dmaengine: mxs-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 18/35] dmaengine: nbpfaxi: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 19/35] dmaengine: pch_dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 20/35] dmaengine: pl330: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 21/35] dmaengine: ppc4xx: " Allen Pais
2020-08-31 10:35 ` Allen Pais [this message]
2020-08-31 10:35 ` [PATCH v3 23/35] dmaengine: sa11x0: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 24/35] dmaengine: sirf-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 25/35] dmaengine: ste_dma40: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 26/35] dmaengine: sun6i: " Allen Pais
2020-08-31 11:23   ` Chen-Yu Tsai
2020-08-31 10:35 ` [PATCH v3 27/35] dmaengine: tegra20: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 28/35] dmaengine: timb_dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 29/35] dmaengine: txx9dmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 30/35] dmaengine: virt-dma: " Allen Pais
2020-08-31 11:30   ` Peter Ujfalusi
2020-08-31 10:35 ` [PATCH v3 31/35] dmaengine: xgene: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 32/35] dmaengine: xilinx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 33/35] dmaengine: plx_dma: " Allen Pais
2020-08-31 15:47   ` Logan Gunthorpe
2020-08-31 15:56     ` Allen
2020-08-31 16:17       ` Logan Gunthorpe
2020-08-31 10:35 ` [PATCH v3 34/35] dmaengine: sf-pdma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 35/35] dmaengine: k3-udma: " Allen Pais
2020-08-31 11:30   ` Peter Ujfalusi
2020-09-18  6:52 ` [PATCH v3 00/35] dmaengine: convert tasklets to use new Vinod Koul
2020-09-21  5:54   ` Allen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831103542.305571-23-allen.lkml@gmail.com \
    --to=allen.lkml@gmail.com \
    --cc=agross@kernel.org \
    --cc=baohua@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=green.wan@sifive.com \
    --cc=jorn.andersson@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=logang@deltatee.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=romain.perier@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sean.wang@mediatek.com \
    --cc=shawnguo@kernel.org \
    --cc=vireshk@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    --cc=zw@zh-kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).