From: Allen Pais <allen.lkml@gmail.com>
To: vkoul@kernel.org
Cc: linus.walleij@linaro.org, vireshk@kernel.org, leoyang.li@nxp.com,
zw@zh-kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
sean.wang@mediatek.com, matthias.bgg@gmail.com,
logang@deltatee.com, agross@kernel.org,
jorn.andersson@linaro.org, green.wan@sifive.com,
baohua@kernel.org, mripard@kernel.org, wens@csie.org,
dmaengine@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH v3 29/35] dmaengine: txx9dmac: convert tasklets to use new tasklet_setup() API
Date: Mon, 31 Aug 2020 16:05:36 +0530 [thread overview]
Message-ID: <20200831103542.305571-30-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200831103542.305571-1-allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
drivers/dma/txx9dmac.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/dma/txx9dmac.c b/drivers/dma/txx9dmac.c
index 628bdf4430c7..5b6b375a257e 100644
--- a/drivers/dma/txx9dmac.c
+++ b/drivers/dma/txx9dmac.c
@@ -601,13 +601,13 @@ static void txx9dmac_scan_descriptors(struct txx9dmac_chan *dc)
}
}
-static void txx9dmac_chan_tasklet(unsigned long data)
+static void txx9dmac_chan_tasklet(struct tasklet_struct *t)
{
int irq;
u32 csr;
struct txx9dmac_chan *dc;
- dc = (struct txx9dmac_chan *)data;
+ dc = from_tasklet(dc, t, tasklet);
csr = channel_readl(dc, CSR);
dev_vdbg(chan2dev(&dc->chan), "tasklet: status=%x\n", csr);
@@ -638,13 +638,13 @@ static irqreturn_t txx9dmac_chan_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static void txx9dmac_tasklet(unsigned long data)
+static void txx9dmac_tasklet(struct tasklet_struct *t)
{
int irq;
u32 csr;
struct txx9dmac_chan *dc;
- struct txx9dmac_dev *ddev = (struct txx9dmac_dev *)data;
+ struct txx9dmac_dev *ddev = from_tasklet(ddev, t, tasklet);
u32 mcr;
int i;
@@ -1113,8 +1113,7 @@ static int __init txx9dmac_chan_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
- tasklet_init(&dc->tasklet, txx9dmac_chan_tasklet,
- (unsigned long)dc);
+ tasklet_setup(&dc->tasklet, txx9dmac_chan_tasklet);
dc->irq = irq;
err = devm_request_irq(&pdev->dev, dc->irq,
txx9dmac_chan_interrupt, 0, dev_name(&pdev->dev), dc);
@@ -1200,8 +1199,7 @@ static int __init txx9dmac_probe(struct platform_device *pdev)
ddev->irq = platform_get_irq(pdev, 0);
if (ddev->irq >= 0) {
- tasklet_init(&ddev->tasklet, txx9dmac_tasklet,
- (unsigned long)ddev);
+ tasklet_setup(&ddev->tasklet, txx9dmac_tasklet);
err = devm_request_irq(&pdev->dev, ddev->irq,
txx9dmac_interrupt, 0, dev_name(&pdev->dev), ddev);
if (err)
--
2.25.1
next prev parent reply other threads:[~2020-08-31 10:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 10:35 [PATCH v3 00/35] dmaengine: convert tasklets to use new Allen Pais
2020-08-31 10:35 ` [PATCH v3 01/35] dmaengine: altera-msgdma: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-31 10:35 ` [PATCH v3 02/35] dmaengine: at_hdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 03/35] dmaengine: at_xdmac: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 04/35] dmaengine: coh901318: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 05/35] dmaengine: dw: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 06/35] dmaengine: ep93xx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 07/35] dmaengine: fsl: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 08/35] dmaengine: imx-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 09/35] dmaengine: ioat: " Allen Pais
2020-08-31 14:47 ` Dave Jiang
2020-08-31 10:35 ` [PATCH v3 10/35] dmaengine: iop_adma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 11/35] dmaengine: ipu: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 12/35] dmaengine: k3dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 13/35] dmaengine: mediatek: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 14/35] dmaengine: mmp: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 15/35] dmaengine: mpc512x: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 16/35] dmaengine: mv_xor: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 17/35] dmaengine: mxs-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 18/35] dmaengine: nbpfaxi: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 19/35] dmaengine: pch_dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 20/35] dmaengine: pl330: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 21/35] dmaengine: ppc4xx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 22/35] dmaengine: qcom: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 23/35] dmaengine: sa11x0: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 24/35] dmaengine: sirf-dma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 25/35] dmaengine: ste_dma40: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 26/35] dmaengine: sun6i: " Allen Pais
2020-08-31 11:23 ` Chen-Yu Tsai
2020-08-31 10:35 ` [PATCH v3 27/35] dmaengine: tegra20: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 28/35] dmaengine: timb_dma: " Allen Pais
2020-08-31 10:35 ` Allen Pais [this message]
2020-08-31 10:35 ` [PATCH v3 30/35] dmaengine: virt-dma: " Allen Pais
2020-08-31 11:30 ` Peter Ujfalusi
2020-08-31 10:35 ` [PATCH v3 31/35] dmaengine: xgene: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 32/35] dmaengine: xilinx: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 33/35] dmaengine: plx_dma: " Allen Pais
2020-08-31 15:47 ` Logan Gunthorpe
2020-08-31 15:56 ` Allen
2020-08-31 16:17 ` Logan Gunthorpe
2020-08-31 10:35 ` [PATCH v3 34/35] dmaengine: sf-pdma: " Allen Pais
2020-08-31 10:35 ` [PATCH v3 35/35] dmaengine: k3-udma: " Allen Pais
2020-08-31 11:30 ` Peter Ujfalusi
2020-09-18 6:52 ` [PATCH v3 00/35] dmaengine: convert tasklets to use new Vinod Koul
2020-09-21 5:54 ` Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831103542.305571-30-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=agross@kernel.org \
--cc=baohua@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=jorn.andersson@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=logang@deltatee.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=romain.perier@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=sean.wang@mediatek.com \
--cc=shawnguo@kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).