* [PATCH] dmaengine: fsl: remove bad channel update
@ 2020-10-01 16:47 Vinod Koul
2020-10-05 4:29 ` Vinod Koul
2020-10-06 5:03 ` Allen
0 siblings, 2 replies; 3+ messages in thread
From: Vinod Koul @ 2020-10-01 16:47 UTC (permalink / raw)
To: dmaengine; +Cc: Vinod Koul, Romain Perier, Allen Pais
Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new
tasklet_setup() API") broke this driver by not removing the old channel
update method.
Fix this by remove the offending call as channel is queried from
tasklet structure.
Fixes: 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/fsl_raid.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index 1ddd7cee2e7a..fdf3500d96a9 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -163,8 +163,6 @@ static void fsl_re_dequeue(struct tasklet_struct *t)
unsigned int count, oub_count;
int found;
- re_chan = dev_get_drvdata((struct device *)data);
-
fsl_re_cleanup_descs(re_chan);
spin_lock_irqsave(&re_chan->desc_lock, flags);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: fsl: remove bad channel update
2020-10-01 16:47 [PATCH] dmaengine: fsl: remove bad channel update Vinod Koul
@ 2020-10-05 4:29 ` Vinod Koul
2020-10-06 5:03 ` Allen
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-10-05 4:29 UTC (permalink / raw)
To: dmaengine; +Cc: Romain Perier, Allen Pais
On 01-10-20, 22:17, Vinod Koul wrote:
> Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new
> tasklet_setup() API") broke this driver by not removing the old channel
> update method.
>
> Fix this by remove the offending call as channel is queried from
> tasklet structure.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: fsl: remove bad channel update
2020-10-01 16:47 [PATCH] dmaengine: fsl: remove bad channel update Vinod Koul
2020-10-05 4:29 ` Vinod Koul
@ 2020-10-06 5:03 ` Allen
1 sibling, 0 replies; 3+ messages in thread
From: Allen @ 2020-10-06 5:03 UTC (permalink / raw)
To: Vinod Koul; +Cc: dmaengine, Romain Perier
> Commit 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new
> tasklet_setup() API") broke this driver by not removing the old channel
> update method.
>
> Fix this by remove the offending call as channel is queried from
> tasklet structure.
>
> Fixes: 59cd818763e8 ("dmaengine: fsl: convert tasklets to use new tasklet_setup() API")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/dma/fsl_raid.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 1ddd7cee2e7a..fdf3500d96a9 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
> @@ -163,8 +163,6 @@ static void fsl_re_dequeue(struct tasklet_struct *t)
> unsigned int count, oub_count;
> int found;
>
> - re_chan = dev_get_drvdata((struct device *)data);
> -
> fsl_re_cleanup_descs(re_chan);
>
> spin_lock_irqsave(&re_chan->desc_lock, flags);
> --
> 2.26.2
>
Thank you.
--
- Allen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-06 5:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 16:47 [PATCH] dmaengine: fsl: remove bad channel update Vinod Koul
2020-10-05 4:29 ` Vinod Koul
2020-10-06 5:03 ` Allen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).