* [PATCH v2] dmaengine: pl330: Remove unreachable code
[not found] <CGME20201016110722epcas5p3e1bc44be4c2b35654b440276448b7c4f@epcas5p3.samsung.com>
@ 2020-10-16 10:33 ` Surendran K
2020-10-28 6:09 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Surendran K @ 2020-10-16 10:33 UTC (permalink / raw)
To: dmaengine, linux-kernel
Cc: vkoul, shaik.ameer, alim.akhtar, pankaj.dubey, Surendran K
_setup_req(..) never returns negative value.
Hence the condition ret < 0 is never met
Signed-off-by: Surendran K <surendran.k@samsung.com>
---
Commit tag is changed
drivers/dma/pl330.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index e9f0101d92fa..8355586c9788 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -1527,8 +1527,6 @@ static int pl330_submit_req(struct pl330_thread *thrd,
/* First dry run to check if req is acceptable */
ret = _setup_req(pl330, 1, thrd, idx, &xs);
- if (ret < 0)
- goto xfer_exit;
if (ret > pl330->mcbufsz / 2) {
dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz (%i/%i)\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dmaengine: pl330: Remove unreachable code
2020-10-16 10:33 ` [PATCH v2] dmaengine: pl330: Remove unreachable code Surendran K
@ 2020-10-28 6:09 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-10-28 6:09 UTC (permalink / raw)
To: Surendran K
Cc: dmaengine, linux-kernel, shaik.ameer, alim.akhtar, pankaj.dubey
On 16-10-20, 16:03, Surendran K wrote:
> _setup_req(..) never returns negative value.
> Hence the condition ret < 0 is never met
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-28 22:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20201016110722epcas5p3e1bc44be4c2b35654b440276448b7c4f@epcas5p3.samsung.com>
2020-10-16 10:33 ` [PATCH v2] dmaengine: pl330: Remove unreachable code Surendran K
2020-10-28 6:09 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).