* [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()
@ 2021-05-18 14:11 Yang Yingliang
2021-05-22 0:01 ` Linus Walleij
2021-05-31 4:17 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-05-18 14:11 UTC (permalink / raw)
To: linux-kernel, dmaengine, linux-arm-kernel; +Cc: vkoul, linus.walleij
Add the missing iounmap() before return from d40_probe()
in the error handling case.
Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/dma/ste_dma40.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index 265d7c07b348..e1827393143f 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -3675,6 +3675,9 @@ static int __init d40_probe(struct platform_device *pdev)
kfree(base->lcla_pool.base_unaligned);
+ if (base->lcpa_base)
+ iounmap(base->lcpa_base);
+
if (base->phy_lcpa)
release_mem_region(base->phy_lcpa,
base->lcpa_size);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()
2021-05-18 14:11 [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe() Yang Yingliang
@ 2021-05-22 0:01 ` Linus Walleij
2021-05-31 4:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2021-05-22 0:01 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, dmaengine, Linux ARM, Vinod Koul
On Tue, May 18, 2021 at 4:09 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
> Add the missing iounmap() before return from d40_probe()
> in the error handling case.
>
> Fixes: 8d318a50b3d7 ("DMAENGINE: Support for ST-Ericssons DMA40 block v3")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe()
2021-05-18 14:11 [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe() Yang Yingliang
2021-05-22 0:01 ` Linus Walleij
@ 2021-05-31 4:17 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-05-31 4:17 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, dmaengine, linux-arm-kernel, linus.walleij
On 18-05-21, 22:11, Yang Yingliang wrote:
> Add the missing iounmap() before return from d40_probe()
> in the error handling case.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-31 4:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 14:11 [PATCH -next] dmaengine: stedma40: add missing iounmap() on error in d40_probe() Yang Yingliang
2021-05-22 0:01 ` Linus Walleij
2021-05-31 4:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).