From: Jason Gunthorpe <jgg@nvidia.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: alex.williamson@redhat.com, kwankhede@nvidia.com,
tglx@linutronix.de, vkoul@kernel.org,
Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
megha.dey@intel.com, jacob.jun.pan@intel.com, yi.l.liu@intel.com,
baolu.lu@intel.com, sanjay.k.kumar@intel.com,
tony.luck@intel.com, dan.j.williams@intel.com,
eric.auger@redhat.com, pbonzini@redhat.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver
Date: Wed, 2 Jun 2021 20:17:47 -0300 [thread overview]
Message-ID: <20210602231747.GK1002214@nvidia.com> (raw)
In-Reply-To: <86cde154-37c7-c00d-b0c6-06b15b50dbf7@intel.com>
On Wed, Jun 02, 2021 at 08:40:51AM -0700, Dave Jiang wrote:
>
> On 5/23/2021 4:22 PM, Jason Gunthorpe wrote:
> > On Fri, May 21, 2021 at 05:19:05PM -0700, Dave Jiang wrote:
> > > Introducing mdev types “1dwq-v1” type. This mdev type allows
> > > allocation of a single dedicated wq from available dedicated wqs. After
> > > a workqueue (wq) is enabled, the user will generate an uuid. On mdev
> > > creation, the mdev driver code will find a dwq depending on the mdev
> > > type. When the create operation is successful, the user generated uuid
> > > can be passed to qemu. When the guest boots up, it should discover a
> > > DSA device when doing PCI discovery.
> > >
> > > For example of “1dwq-v1” type:
> > > 1. Enable wq with “mdev” wq type
> > > 2. A user generated uuid.
> > > 3. The uuid is written to the mdev class sysfs path:
> > > echo $UUID > /sys/class/mdev_bus/0000\:00\:0a.0/mdev_supported_types/idxd-1dwq-v1/create
> > > 4. Pass the following parameter to qemu:
> > > "-device vfio-pci,sysfsdev=/sys/bus/pci/devices/0000:00:0a.0/$UUID"
> > So the idxd core driver knows to create a "vfio" wq with its own much
> > machinery but you still want to involve the horrible mdev guid stuff?
> >
> > Why??
>
> Are you referring to calling mdev_device_create() directly in the mdev
> idxd_driver probe?
No, just call vfio_register_group_dev and forget about mdev.
> I think this would work with our dedicated wq where a single mdev
> can be assigned to a wq.
Ok, sounds great
> However, later on when we need to support shared wq where we can
> create multiple mdev per wq, we'll need an entry point to do so. In
> the name of making things consistent from user perspective, going
> through sysfs seems the way to do it.
Why not use your already very complicated idxd sysfs to do this?
Jason
next prev parent reply other threads:[~2021-06-02 23:17 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 0:19 [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Dave Jiang
2021-05-22 0:19 ` [PATCH v6 01/20] vfio/mdev: idxd: add theory of operation documentation for idxd mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 02/20] dmaengine: idxd: add external module driver support for dsa_bus_type Dave Jiang
2021-05-22 0:19 ` [PATCH v6 03/20] dmaengine: idxd: add IMS offset and size retrieval code Dave Jiang
2021-05-22 0:19 ` [PATCH v6 04/20] dmaengine: idxd: add portal offset for IMS portals Dave Jiang
2021-05-22 0:19 ` [PATCH v6 05/20] vfio: mdev: common lib code for setting up Interrupt Message Store Dave Jiang
2021-05-24 0:02 ` Jason Gunthorpe
2021-05-28 1:49 ` Dave Jiang
2021-05-28 12:21 ` Jason Gunthorpe
2021-05-28 16:37 ` Dave Jiang
2021-05-28 16:39 ` Jason Gunthorpe
2021-05-31 10:41 ` Thomas Gleixner
2021-05-31 13:48 ` Thomas Gleixner
2021-05-31 15:24 ` Jason Gunthorpe
2021-06-08 15:57 ` Dave Jiang
2021-06-08 17:22 ` Jason Gunthorpe
2021-06-10 13:00 ` Thomas Gleixner
2021-05-22 0:19 ` [PATCH v6 06/20] vfio/mdev: idxd: add PCI config for read/write for mdev Dave Jiang
2021-05-22 0:19 ` [PATCH v6 07/20] vfio/mdev: idxd: Add administrative commands emulation " Dave Jiang
2021-05-22 0:19 ` [PATCH v6 08/20] vfio/mdev: idxd: Add mdev device context initialization Dave Jiang
2021-05-22 0:20 ` [PATCH v6 09/20] vfio/mdev: Add mmio read/write support for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 10/20] vfio/mdev: idxd: add mdev type as a new wq type Dave Jiang
2021-05-22 0:20 ` [PATCH v6 11/20] vfio/mdev: idxd: Add basic driver setup for idxd mdev Dave Jiang
2021-05-23 23:27 ` Jason Gunthorpe
2021-05-23 23:52 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 12/20] vfio: move VFIO PCI macros to common header Dave Jiang
2021-06-04 3:47 ` Alex Williamson
2021-05-22 0:20 ` [PATCH v6 13/20] vfio/mdev: idxd: add mdev driver registration and helper functions Dave Jiang
2021-05-23 23:32 ` Jason Gunthorpe
2021-05-23 23:46 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 14/20] vfio/mdev: idxd: add 1dwq-v1 mdev type Dave Jiang
2021-05-23 23:47 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 15/20] vfio/mdev: idxd: ims domain setup for the vdcm Dave Jiang
2021-05-23 23:50 ` Jason Gunthorpe
2021-05-27 0:22 ` Dave Jiang
2021-05-27 0:54 ` Jason Gunthorpe
2021-05-27 1:15 ` Dave Jiang
2021-05-27 1:41 ` Raj, Ashok
2021-05-27 13:36 ` Jason Gunthorpe
2021-05-31 14:02 ` Thomas Gleixner
2021-05-31 16:57 ` Jason Gunthorpe
2021-05-31 23:55 ` Thomas Gleixner
2021-06-01 12:16 ` Jason Gunthorpe
2021-05-22 0:20 ` [PATCH v6 16/20] vfio/mdev: idxd: add new wq state for mdev Dave Jiang
2021-05-22 0:20 ` [PATCH v6 17/20] vfio/mdev: idxd: add error notification from host driver to mediated device Dave Jiang
2021-05-22 0:20 ` [PATCH v6 18/20] vfio: move vfio_pci_set_ctx_trigger_single to common code Dave Jiang
2021-05-22 0:21 ` [PATCH v6 19/20] vfio: mdev: Add device request interface Dave Jiang
2021-05-23 22:38 ` Jason Gunthorpe
2021-05-22 0:21 ` [PATCH v6 20/20] vfio: mdev: idxd: setup request interrupt Dave Jiang
2021-05-23 23:22 ` [PATCH v6 00/20] Add VFIO mediated device support and DEV-MSI support for the idxd driver Jason Gunthorpe
2021-06-02 15:40 ` Dave Jiang
2021-06-02 23:17 ` Jason Gunthorpe [this message]
2021-06-03 1:11 ` Tian, Kevin
2021-06-03 1:49 ` Jason Gunthorpe
2021-06-03 5:52 ` Tian, Kevin
2021-06-03 11:23 ` Jason Gunthorpe
2021-06-04 3:40 ` Alex Williamson
2021-06-07 6:22 ` Tian, Kevin
2021-06-07 18:13 ` Dave Jiang
2021-06-07 19:11 ` Jason Gunthorpe
2021-06-08 16:02 ` Dave Jiang
2021-06-11 18:21 ` Dave Jiang
2021-06-11 18:29 ` Jason Gunthorpe
2021-06-07 18:28 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602231747.GK1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@intel.com \
--cc=pbonzini@redhat.com \
--cc=sanjay.k.kumar@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).