From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jingoo Han <jingoohan1@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v5 01/24] dmaengine: Fix dma_slave_config.dst_addr description
Date: Mon, 22 Aug 2022 21:53:09 +0300 [thread overview]
Message-ID: <20220822185332.26149-2-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20220822185332.26149-1-Sergey.Semin@baikalelectronics.ru>
Most likely due to a copy-paste mistake the dst_addr member of the
dma_slave_config structure has been marked as ignored if the !source!
address belong to the memory. That is relevant to the src_addr field of
the structure while the dst_addr field as containing a destination device
address is supposed to be ignored if the destination is the CPU memory.
Let's fix the field description accordingly.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-By: Vinod Koul <vkoul@kernel.org>
---
include/linux/dmaengine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
index c923f4e60f24..0c020682d894 100644
--- a/include/linux/dmaengine.h
+++ b/include/linux/dmaengine.h
@@ -394,7 +394,7 @@ enum dma_slave_buswidth {
* should be read (RX), if the source is memory this argument is
* ignored.
* @dst_addr: this is the physical address where DMA slave data
- * should be written (TX), if the source is memory this argument
+ * should be written (TX), if the destination is memory this argument
* is ignored.
* @src_addr_width: this is the width in bytes of the source (RX)
* register where DMA data shall be read. If the source
--
2.35.1
next prev parent reply other threads:[~2022-08-22 18:54 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:53 [PATCH RESEND v5 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2022-08-22 18:53 ` Serge Semin [this message]
2022-08-22 18:53 ` [PATCH RESEND v5 02/24] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 03/24] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 04/24] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 05/24] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 06/24] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 07/24] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 08/24] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 09/24] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 10/24] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 11/24] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 12/24] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 13/24] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 14/24] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 15/24] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 16/24] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 17/24] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 18/24] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 19/24] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 20/24] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 21/24] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 22/24] dmaengine: dw-edma: Bypass dma-ranges mapping for the local setup Serge Semin
2022-08-31 9:17 ` Robin Murphy
2022-09-12 1:24 ` Serge Semin
2022-09-26 14:08 ` Robin Murphy
2022-09-27 10:48 ` Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 23/24] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2022-08-22 18:53 ` [PATCH RESEND v5 24/24] PCI: dwc: Add DW eDMA engine support Serge Semin
2022-08-23 15:49 ` Manivannan Sadhasivam
2022-08-24 14:22 ` Serge Semin
2022-08-24 16:51 ` Bjorn Helgaas
2022-08-24 18:13 ` Serge Semin
2022-08-24 18:17 ` Bjorn Helgaas
2022-08-25 5:16 ` Serge Semin
2022-08-25 16:04 ` Bjorn Helgaas
2022-08-25 17:06 ` Serge Semin
2022-08-23 15:45 ` [PATCH RESEND v5 00/24] dmaengine: dw-edma: Add RP/EP local DMA controllers support Manivannan Sadhasivam
2022-08-24 14:07 ` Serge Semin
2022-08-25 4:42 ` Vinod Koul
2022-08-25 5:04 ` Serge Semin
2022-08-25 8:44 ` Vinod Koul
2022-08-25 11:28 ` Serge Semin
2022-08-24 16:39 ` Bjorn Helgaas
2022-08-24 18:00 ` Serge Semin
2022-10-25 7:59 ` Manivannan Sadhasivam
2022-10-25 20:50 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822185332.26149-2-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).