* [PATCH 0/2] SDM670 GPI DMA support
@ 2022-09-23 1:54 Richard Acayan
2022-09-23 1:54 ` [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
2022-09-23 1:54 ` [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support Richard Acayan
0 siblings, 2 replies; 5+ messages in thread
From: Richard Acayan @ 2022-09-23 1:54 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree,
Richard Acayan
This patch series adds the compatible string for GPI DMA, needed for the
GENI interface, on Snapdragon 670.
Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
drivers/dma/qcom/gpi.c | 1 +
2 files changed, 2 insertions(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670
2022-09-23 1:54 [PATCH 0/2] SDM670 GPI DMA support Richard Acayan
@ 2022-09-23 1:54 ` Richard Acayan
2022-09-23 9:54 ` Krzysztof Kozlowski
2022-09-23 1:54 ` [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support Richard Acayan
1 sibling, 1 reply; 5+ messages in thread
From: Richard Acayan @ 2022-09-23 1:54 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree,
Richard Acayan
The Snapdragon 670 uses GPI DMA for its GENI interface. Add a compatible
string for it in the documentation.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
index eabf8a76d3a0..cabe6a51db07 100644
--- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
+++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
enum:
- qcom,sc7280-gpi-dma
+ - qcom,sdm670-gpi-dma
- qcom,sdm845-gpi-dma
- qcom,sm6350-gpi-dma
- qcom,sm8150-gpi-dma
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support
2022-09-23 1:54 [PATCH 0/2] SDM670 GPI DMA support Richard Acayan
2022-09-23 1:54 ` [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
@ 2022-09-23 1:54 ` Richard Acayan
2022-09-23 9:54 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Richard Acayan @ 2022-09-23 1:54 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree,
Richard Acayan
The Snapdragon 670 uses GPI DMA for its GENI interface. Add support for
it.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/dma/qcom/gpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 89839864b4ec..9634be23e46b 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -2287,6 +2287,7 @@ static int gpi_probe(struct platform_device *pdev)
static const struct of_device_id gpi_of_match[] = {
{ .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
+ { .compatible = "qcom,sdm670-gpi-dma", .data = (void *)0x0 },
{ .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
{ .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
{ .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670
2022-09-23 1:54 ` [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
@ 2022-09-23 9:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-23 9:54 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree
On 23/09/2022 03:54, Richard Acayan wrote:
> The Snapdragon 670 uses GPI DMA for its GENI interface. Add a compatible
> string for it in the documentation.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> index eabf8a76d3a0..cabe6a51db07 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> enum:
> - qcom,sc7280-gpi-dma
> + - qcom,sdm670-gpi-dma
> - qcom,sdm845-gpi-dma
SDM670, SDM854, SM8150 have all the same xPU3 block. They are
compatible. Are we sure we want to keep growing the list in the driver?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support
2022-09-23 1:54 ` [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support Richard Acayan
@ 2022-09-23 9:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-23 9:54 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, dmaengine, devicetree
On 23/09/2022 03:54, Richard Acayan wrote:
> The Snapdragon 670 uses GPI DMA for its GENI interface. Add support for
> it.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/dma/qcom/gpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 89839864b4ec..9634be23e46b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -2287,6 +2287,7 @@ static int gpi_probe(struct platform_device *pdev)
>
> static const struct of_device_id gpi_of_match[] = {
> { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 },
> + { .compatible = "qcom,sdm670-gpi-dma", .data = (void *)0x0 },
> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 },
> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
> { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 },
I vote for just one entry with 0x0 offset...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-23 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 1:54 [PATCH 0/2] SDM670 GPI DMA support Richard Acayan
2022-09-23 1:54 ` [PATCH 1/2] dt-bindings: dma: qcom: gpi: add compatible for sdm670 Richard Acayan
2022-09-23 9:54 ` Krzysztof Kozlowski
2022-09-23 1:54 ` [PATCH 2/2] dmaengine: qcom: gpi: add sdm670 support Richard Acayan
2022-09-23 9:54 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).