* [PATCH 5.8 070/255] dmaengine: idxd: fix PCI_MSI build errors
[not found] <20200901151000.800754757@linuxfoundation.org>
@ 2020-09-01 15:08 ` Greg Kroah-Hartman
2020-09-01 17:13 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-09-01 15:08 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, stable, Randy Dunlap, Dave Jiang, dmaengine,
Vinod Koul, Sasha Levin
[ Upstream commit d6a7bb869dd8a516901591136a9a895fd829d6c6 ]
Fix build errors when CONFIG_PCI_MSI is not enabled by making the
driver depend on PCI_MSI:
ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/9dee3f46-70d9-ea75-10cb-5527ab297d1d@infradead.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index de41d7928bff2..984354ca877de 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -285,6 +285,7 @@ config INTEL_IDMA64
config INTEL_IDXD
tristate "Intel Data Accelerators support"
depends on PCI && X86_64
+ depends on PCI_MSI
select DMA_ENGINE
select SBITMAP
help
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5.8 070/255] dmaengine: idxd: fix PCI_MSI build errors
2020-09-01 15:08 ` [PATCH 5.8 070/255] dmaengine: idxd: fix PCI_MSI build errors Greg Kroah-Hartman
@ 2020-09-01 17:13 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2020-09-01 17:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-kernel
Cc: stable, Randy Dunlap, dmaengine, Vinod Koul, Sasha Levin
On 9/1/2020 8:08 AM, Greg Kroah-Hartman wrote:
> [ Upstream commit d6a7bb869dd8a516901591136a9a895fd829d6c6 ]
>
> Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> driver depend on PCI_MSI:
>
> ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>
> Link: https://lore.kernel.org/r/9dee3f46-70d9-ea75-10cb-5527ab297d1d@infradead.org
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index de41d7928bff2..984354ca877de 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -285,6 +285,7 @@ config INTEL_IDMA64
> config INTEL_IDXD
> tristate "Intel Data Accelerators support"
> depends on PCI && X86_64
> + depends on PCI_MSI
> select DMA_ENGINE
> select SBITMAP
> help
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-01 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200901151000.800754757@linuxfoundation.org>
2020-09-01 15:08 ` [PATCH 5.8 070/255] dmaengine: idxd: fix PCI_MSI build errors Greg Kroah-Hartman
2020-09-01 17:13 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).