From: Dmitry Osipenko <digetx@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Vinod Koul <vkoul@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity
Date: Tue, 2 Jul 2019 12:25:17 +0300 [thread overview]
Message-ID: <8b4fbdb5-c6fa-6481-4894-6c2c77c23195@gmail.com> (raw)
In-Reply-To: <20190627194728.8948-1-digetx@gmail.com>
27.06.2019 22:47, Dmitry Osipenko пишет:
> Tegra's APB DMA engine updates words counter after each transferred burst
> of data, hence it can report transfer's residual with more fidelity which
> may be required in cases like audio playback. In particular this fixes
> audio stuttering during playback in a chromium web browser. The patch is
> based on the original work that was made by Ben Dooks and a patch from
> downstream kernel. It was tested on Tegra20 and Tegra30 devices.
>
> Link: https://lore.kernel.org/lkml/20190424162348.23692-1-ben.dooks@codethink.co.uk/
> Link: https://nv-tegra.nvidia.com/gitweb/?p=linux-4.4.git;a=commit;h=c7bba40c6846fbf3eaad35c4472dcc7d8bbc02e5
> Inspired-by: Ben Dooks <ben.dooks@codethink.co.uk>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>
> Changelog:
>
> v3: Added workaround for a hardware design shortcoming that results
> in a words counter wraparound before end-of-transfer bit is set
> in a cyclic mode.
>
> v2: Addressed review comments made by Jon Hunter to v1. We won't try
> to get words count if dma_desc is on free list as it will result
> in a NULL dereference because this case wasn't handled properly.
>
> The residual value is now updated properly, avoiding potential
> integer overflow by adding the "bytes" to the "bytes_transferred"
> instead of the subtraction.
Is there still any chance to get this into 5.3? Will be very nice! Jon / Vinod ?
next prev parent reply other threads:[~2019-07-02 9:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 19:47 [PATCH v3] dmaengine: tegra-apb: Support per-burst residue granularity Dmitry Osipenko
2019-07-02 9:25 ` Dmitry Osipenko [this message]
2019-07-02 11:20 ` Jon Hunter
2019-07-02 11:37 ` Dmitry Osipenko
2019-07-02 11:56 ` Dmitry Osipenko
2019-07-02 12:04 ` Dmitry Osipenko
2019-07-02 12:27 ` Dmitry Osipenko
2019-07-02 12:56 ` Jon Hunter
2019-07-02 12:54 ` Jon Hunter
2019-07-02 12:57 ` Jon Hunter
2019-07-02 13:22 ` Dmitry Osipenko
2019-07-02 13:41 ` Jon Hunter
2019-07-02 14:41 ` Dmitry Osipenko
2019-07-02 15:27 ` Jon Hunter
2019-07-02 15:29 ` Jon Hunter
2019-07-02 15:37 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4fbdb5-c6fa-6481-4894-6c2c77c23195@gmail.com \
--to=digetx@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).