* [PATCH] dmaengine: xilinx_dpdma: fix platform_get_irq.cocci warning
@ 2022-03-03 13:03 Yihao Han
2022-03-03 14:55 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-03 13:03 UTC (permalink / raw)
To: Hyun Kwon, Laurent Pinchart, Vinod Koul, Michal Simek, dmaengine,
linux-arm-kernel, linux-kernel
Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index b0f4948b00a5..f708808d73ba 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
dpdma_hw_init(xdev);
xdev->irq = platform_get_irq(pdev, 0);
- if (xdev->irq < 0) {
- dev_err(xdev->dev, "failed to get platform irq\n");
+ if (xdev->irq < 0)
return xdev->irq;
- }
ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
dev_name(xdev->dev), xdev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: xilinx_dpdma: fix platform_get_irq.cocci warning
2022-03-03 13:03 [PATCH] dmaengine: xilinx_dpdma: fix platform_get_irq.cocci warning Yihao Han
@ 2022-03-03 14:55 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2022-03-03 14:55 UTC (permalink / raw)
To: Yihao Han, Hyun Kwon, Laurent Pinchart, Vinod Koul, Michal Simek,
dmaengine, linux-arm-kernel, linux-kernel
Cc: kernel
On 3/3/22 14:03, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index b0f4948b00a5..f708808d73ba 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
> dpdma_hw_init(xdev);
>
> xdev->irq = platform_get_irq(pdev, 0);
> - if (xdev->irq < 0) {
> - dev_err(xdev->dev, "failed to get platform irq\n");
> + if (xdev->irq < 0)
> return xdev->irq;
> - }
>
> ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
> dev_name(xdev->dev), xdev);
Make sense.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-03 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 13:03 [PATCH] dmaengine: xilinx_dpdma: fix platform_get_irq.cocci warning Yihao Han
2022-03-03 14:55 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).