* [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
@ 2020-11-07 12:20 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings 周琰杰 (Zhou Yanjie)
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-11-07 12:20 UTC (permalink / raw)
To: Zubair.Kakakhel, vkoul, paul, robh+dt
Cc: linux-kernel, devicetree, dmaengine, dongsheng.qiu, aric.pzqi,
rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin
Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from Ingenic.
周琰杰 (Zhou Yanjie) (2):
dt-bindings: dmaengine: Add JZ4775 bindings.
dt-bindings: dmaengine: Add X2000 bindings.
include/dt-bindings/dma/jz4775-dma.h | 44 +++++++++++++++++++++++++++++
include/dt-bindings/dma/x2000-dma.h | 54 ++++++++++++++++++++++++++++++++++++
2 files changed, 98 insertions(+)
create mode 100644 include/dt-bindings/dma/jz4775-dma.h
create mode 100644 include/dt-bindings/dma/x2000-dma.h
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings.
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
@ 2020-11-07 12:20 ` 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 2/2] dt-bindings: dmaengine: Add X2000 bindings 周琰杰 (Zhou Yanjie)
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-11-07 12:20 UTC (permalink / raw)
To: Zubair.Kakakhel, vkoul, paul, robh+dt
Cc: linux-kernel, devicetree, dmaengine, dongsheng.qiu, aric.pzqi,
rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin
Add the dmaengine bindings for the JZ4775 SoC from Ingenic.
Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Acked-by: Rob Herring <robh@kernel.org>
---
include/dt-bindings/dma/jz4775-dma.h | 44 ++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100644 include/dt-bindings/dma/jz4775-dma.h
diff --git a/include/dt-bindings/dma/jz4775-dma.h b/include/dt-bindings/dma/jz4775-dma.h
new file mode 100644
index 000000000000..8d27e2c69dca
--- /dev/null
+++ b/include/dt-bindings/dma/jz4775-dma.h
@@ -0,0 +1,44 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * This header provides macros for JZ4775 DMA bindings.
+ *
+ * Copyright (c) 2020 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
+ */
+
+#ifndef __DT_BINDINGS_DMA_JZ4775_DMA_H__
+#define __DT_BINDINGS_DMA_JZ4775_DMA_H__
+
+/*
+ * Request type numbers for the JZ4775 DMA controller (written to the DRTn
+ * register for the channel).
+ */
+#define JZ4775_DMA_I2S0_TX 0x6
+#define JZ4775_DMA_I2S0_RX 0x7
+#define JZ4775_DMA_AUTO 0x8
+#define JZ4775_DMA_SADC_RX 0x9
+#define JZ4775_DMA_UART3_TX 0x0e
+#define JZ4775_DMA_UART3_RX 0x0f
+#define JZ4775_DMA_UART2_TX 0x10
+#define JZ4775_DMA_UART2_RX 0x11
+#define JZ4775_DMA_UART1_TX 0x12
+#define JZ4775_DMA_UART1_RX 0x13
+#define JZ4775_DMA_UART0_TX 0x14
+#define JZ4775_DMA_UART0_RX 0x15
+#define JZ4775_DMA_SSI0_TX 0x16
+#define JZ4775_DMA_SSI0_RX 0x17
+#define JZ4775_DMA_MSC0_TX 0x1a
+#define JZ4775_DMA_MSC0_RX 0x1b
+#define JZ4775_DMA_MSC1_TX 0x1c
+#define JZ4775_DMA_MSC1_RX 0x1d
+#define JZ4775_DMA_MSC2_TX 0x1e
+#define JZ4775_DMA_MSC2_RX 0x1f
+#define JZ4775_DMA_PCM0_TX 0x20
+#define JZ4775_DMA_PCM0_RX 0x21
+#define JZ4775_DMA_SMB0_TX 0x24
+#define JZ4775_DMA_SMB0_RX 0x25
+#define JZ4775_DMA_SMB1_TX 0x26
+#define JZ4775_DMA_SMB1_RX 0x27
+#define JZ4775_DMA_SMB2_TX 0x28
+#define JZ4775_DMA_SMB2_RX 0x29
+
+#endif /* __DT_BINDINGS_DMA_JZ4775_DMA_H__ */
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RESEND 2/2] dt-bindings: dmaengine: Add X2000 bindings.
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings 周琰杰 (Zhou Yanjie)
@ 2020-11-07 12:20 ` 周琰杰 (Zhou Yanjie)
2020-11-10 8:54 ` [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs Paul Cercueil
2020-11-18 10:56 ` Vinod Koul
3 siblings, 0 replies; 7+ messages in thread
From: 周琰杰 (Zhou Yanjie) @ 2020-11-07 12:20 UTC (permalink / raw)
To: Zubair.Kakakhel, vkoul, paul, robh+dt
Cc: linux-kernel, devicetree, dmaengine, dongsheng.qiu, aric.pzqi,
rick.tyliu, yanfei.li, sernia.zhou, zhenwenjin
Add the dmaengine bindings for the X2000 SoC from Ingenic.
Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Acked-by: Rob Herring <robh@kernel.org>
---
include/dt-bindings/dma/x2000-dma.h | 54 +++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
create mode 100644 include/dt-bindings/dma/x2000-dma.h
diff --git a/include/dt-bindings/dma/x2000-dma.h b/include/dt-bindings/dma/x2000-dma.h
new file mode 100644
index 000000000000..db2cd4830b00
--- /dev/null
+++ b/include/dt-bindings/dma/x2000-dma.h
@@ -0,0 +1,54 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * This header provides macros for X2000 DMA bindings.
+ *
+ * Copyright (c) 2020 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
+ */
+
+#ifndef __DT_BINDINGS_DMA_X2000_DMA_H__
+#define __DT_BINDINGS_DMA_X2000_DMA_H__
+
+/*
+ * Request type numbers for the X2000 DMA controller (written to the DRTn
+ * register for the channel).
+ */
+#define X2000_DMA_AUTO 0x8
+#define X2000_DMA_UART5_TX 0xa
+#define X2000_DMA_UART5_RX 0xb
+#define X2000_DMA_UART4_TX 0xc
+#define X2000_DMA_UART4_RX 0xd
+#define X2000_DMA_UART3_TX 0xe
+#define X2000_DMA_UART3_RX 0xf
+#define X2000_DMA_UART2_TX 0x10
+#define X2000_DMA_UART2_RX 0x11
+#define X2000_DMA_UART1_TX 0x12
+#define X2000_DMA_UART1_RX 0x13
+#define X2000_DMA_UART0_TX 0x14
+#define X2000_DMA_UART0_RX 0x15
+#define X2000_DMA_SSI0_TX 0x16
+#define X2000_DMA_SSI0_RX 0x17
+#define X2000_DMA_SSI1_TX 0x18
+#define X2000_DMA_SSI1_RX 0x19
+#define X2000_DMA_I2C0_TX 0x24
+#define X2000_DMA_I2C0_RX 0x25
+#define X2000_DMA_I2C1_TX 0x26
+#define X2000_DMA_I2C1_RX 0x27
+#define X2000_DMA_I2C2_TX 0x28
+#define X2000_DMA_I2C2_RX 0x29
+#define X2000_DMA_I2C3_TX 0x2a
+#define X2000_DMA_I2C3_RX 0x2b
+#define X2000_DMA_I2C4_TX 0x2c
+#define X2000_DMA_I2C4_RX 0x2d
+#define X2000_DMA_I2C5_TX 0x2e
+#define X2000_DMA_I2C5_RX 0x2f
+#define X2000_DMA_UART6_TX 0x30
+#define X2000_DMA_UART6_RX 0x31
+#define X2000_DMA_UART7_TX 0x32
+#define X2000_DMA_UART7_RX 0x33
+#define X2000_DMA_UART8_TX 0x34
+#define X2000_DMA_UART8_RX 0x35
+#define X2000_DMA_UART9_TX 0x36
+#define X2000_DMA_UART9_RX 0x37
+#define X2000_DMA_SADC_RX 0x38
+
+#endif /* __DT_BINDINGS_DMA_X2000_DMA_H__ */
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 2/2] dt-bindings: dmaengine: Add X2000 bindings 周琰杰 (Zhou Yanjie)
@ 2020-11-10 8:54 ` Paul Cercueil
2020-11-18 10:55 ` Vinod Koul
2020-11-18 10:56 ` Vinod Koul
3 siblings, 1 reply; 7+ messages in thread
From: Paul Cercueil @ 2020-11-10 8:54 UTC (permalink / raw)
To: 周琰杰
Cc: Zubair.Kakakhel, vkoul, robh+dt, linux-kernel, devicetree,
dmaengine, dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li,
sernia.zhou, zhenwenjin
Hi Zhou,
Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> a écrit :
> Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from
> Ingenic.
>
> 周琰杰 (Zhou Yanjie) (2):
> dt-bindings: dmaengine: Add JZ4775 bindings.
> dt-bindings: dmaengine: Add X2000 bindings.
>
> include/dt-bindings/dma/jz4775-dma.h | 44
> +++++++++++++++++++++++++++++
> include/dt-bindings/dma/x2000-dma.h | 54
> ++++++++++++++++++++++++++++++++++++
If that's up to me, these macros aren't really needed, and you can put
the values directly in the dma cells. This is done already in
jz4740.dtsi, jz4725b.dtsi and jz4770.dtsi.
Cheers,
-Paul
> 2 files changed, 98 insertions(+)
> create mode 100644 include/dt-bindings/dma/jz4775-dma.h
> create mode 100644 include/dt-bindings/dma/x2000-dma.h
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
2020-11-10 8:54 ` [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs Paul Cercueil
@ 2020-11-18 10:55 ` Vinod Koul
2020-11-18 10:59 ` Paul Cercueil
0 siblings, 1 reply; 7+ messages in thread
From: Vinod Koul @ 2020-11-18 10:55 UTC (permalink / raw)
To: Paul Cercueil
Cc: 周琰杰,
Zubair.Kakakhel, robh+dt, linux-kernel, devicetree, dmaengine,
dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
zhenwenjin
On 10-11-20, 08:54, Paul Cercueil wrote:
> Hi Zhou,
>
> Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> a écrit :
> > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from
> > Ingenic.
> >
> > 周琰杰 (Zhou Yanjie) (2):
> > dt-bindings: dmaengine: Add JZ4775 bindings.
> > dt-bindings: dmaengine: Add X2000 bindings.
> >
> > include/dt-bindings/dma/jz4775-dma.h | 44 +++++++++++++++++++++++++++++
> > include/dt-bindings/dma/x2000-dma.h | 54
> > ++++++++++++++++++++++++++++++++++++
>
> If that's up to me, these macros aren't really needed, and you can put the
> values directly in the dma cells. This is done already in jz4740.dtsi,
> jz4725b.dtsi and jz4770.dtsi.
But that is not really nice, it is good to define these rather than put
numbers, the include/dt-bindings exists for this sole reason!
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
` (2 preceding siblings ...)
2020-11-10 8:54 ` [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs Paul Cercueil
@ 2020-11-18 10:56 ` Vinod Koul
3 siblings, 0 replies; 7+ messages in thread
From: Vinod Koul @ 2020-11-18 10:56 UTC (permalink / raw)
To: 周琰杰 (Zhou Yanjie)
Cc: Zubair.Kakakhel, paul, robh+dt, linux-kernel, devicetree,
dmaengine, dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li,
sernia.zhou, zhenwenjin
On 07-11-20, 20:20, 周琰杰 (Zhou Yanjie) wrote:
> Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC from Ingenic.
>
> 周琰杰 (Zhou Yanjie) (2):
> dt-bindings: dmaengine: Add JZ4775 bindings.
> dt-bindings: dmaengine: Add X2000 bindings.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs.
2020-11-18 10:55 ` Vinod Koul
@ 2020-11-18 10:59 ` Paul Cercueil
0 siblings, 0 replies; 7+ messages in thread
From: Paul Cercueil @ 2020-11-18 10:59 UTC (permalink / raw)
To: Vinod Koul
Cc: 周琰杰,
Zubair.Kakakhel, robh+dt, linux-kernel, devicetree, dmaengine,
dongsheng.qiu, aric.pzqi, rick.tyliu, yanfei.li, sernia.zhou,
zhenwenjin
Le mer. 18 nov. 2020 à 16:25, Vinod Koul <vkoul@kernel.org> a écrit :
> On 10-11-20, 08:54, Paul Cercueil wrote:
>> Hi Zhou,
>>
>> Le sam. 7 nov. 2020 à 20:20, 周琰杰 (Zhou Yanjie)
>> <zhouyanjie@wanyeetech.com> a écrit :
>> > Add the dmaengine bindings for the JZ4775 SoC and the X2000 SoC
>> from
>> > Ingenic.
>> >
>> > 周琰杰 (Zhou Yanjie) (2):
>> > dt-bindings: dmaengine: Add JZ4775 bindings.
>> > dt-bindings: dmaengine: Add X2000 bindings.
>> >
>> > include/dt-bindings/dma/jz4775-dma.h | 44
>> +++++++++++++++++++++++++++++
>> > include/dt-bindings/dma/x2000-dma.h | 54
>> > ++++++++++++++++++++++++++++++++++++
>>
>> If that's up to me, these macros aren't really needed, and you can
>> put the
>> values directly in the dma cells. This is done already in
>> jz4740.dtsi,
>> jz4725b.dtsi and jz4770.dtsi.
>
> But that is not really nice, it is good to define these rather than
> put
> numbers, the include/dt-bindings exists for this sole reason!
The macros in include/dt-bindings exist for when the C code also needs
them (e.g. IRQ_TYPE_EDGE_RISING), and not when they are only used in
devicetree.
Things like IRQ numbers are never defined in include/dt-bindings,
because they don't have to be...
-Paul
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-18 11:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-07 12:20 [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 1/2] dt-bindings: dmaengine: Add JZ4775 bindings 周琰杰 (Zhou Yanjie)
2020-11-07 12:20 ` [PATCH RESEND 2/2] dt-bindings: dmaengine: Add X2000 bindings 周琰杰 (Zhou Yanjie)
2020-11-10 8:54 ` [PATCH RESEND 0/2] Add dmaengine bindings for the JZ4775 and the X2000 SoCs Paul Cercueil
2020-11-18 10:55 ` Vinod Koul
2020-11-18 10:59 ` Paul Cercueil
2020-11-18 10:56 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).