From: "Tian, Kevin" <kevin.tian@intel.com>
To: Jason Gunthorpe <jgg@mellanox.com>, "Jiang, Dave" <dave.jiang@intel.com>
Cc: "vkoul@kernel.org" <vkoul@kernel.org>,
"Dey, Megha" <megha.dey@intel.com>,
"maz@kernel.org" <maz@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"Lu, Baolu" <baolu.lu@intel.com>,
"Kumar, Sanjay K" <sanjay.k.kumar@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Lin, Jing" <jing.lin@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"parav@mellanox.com" <parav@mellanox.com>,
"Hansen, Dave" <dave.hansen@intel.com>,
"netanelg@mellanox.com" <netanelg@mellanox.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>,
"yan.y.zhao@linux.intel.com" <yan.y.zhao@linux.intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Ortiz, Samuel" <samuel.ortiz@intel.com>,
"Hossain, Mona" <mona.hossain@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver
Date: Tue, 21 Jul 2020 23:54:49 +0000 [thread overview]
Message-ID: <CY4PR11MB1638103EC73DD9C025F144C98C780@CY4PR11MB1638.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200721164527.GD2021248@mellanox.com>
> From: Jason Gunthorpe <jgg@mellanox.com>
> Sent: Wednesday, July 22, 2020 12:45 AM
>
> > Link to previous discussions with Jason:
> > https://lore.kernel.org/lkml/57296ad1-20fe-caf2-b83f-
> 46d823ca0b5f@intel.com/
> > The emulation part that can be moved to user space is very small due to
> the majority of the
> > emulations being control bits and need to reside in the kernel. We can
> revisit the necessity of
> > moving the small emulation part to userspace and required architectural
> changes at a later time.
>
> The point here is that you already have a user space interface for
> these queues that already has kernel support to twiddle the control
> bits. Generally I'd expect extending that existing kernel code to do
> the small bit more needed for mapping the queue through to PCI
> emulation to be smaller than the 2kloc of new code here to put all the
> emulation and support framework in the kernel, and exposes a lower
> attack surface of kernel code to the guest.
>
We discussed in v1 about why extending user space interface is not a
strong motivation at current stage:
https://lore.kernel.org/lkml/20200513124016.GG19158@mellanox.com/
In a nutshell, applications don't require raw WQ controllability as guest
kernel drivers may expect. Extending DSA user space interface to be another
passthrough interface just for virtualization needs is less compelling than
leveraging established VFIO/mdev framework (with the major merit that
existing user space VMMs just work w/o any change as long as they already
support VFIO uAPI).
And in this version we split previous 2kloc mdev patch into three parts:
[09] mdev framework and callbacks; [10] mmio/pci_cfg emulation; and
[11] handling of control commands. Only patch[10] is purely about
emulation (~500LOC), while the other two parts are tightly coupled to
physical resource management.
In last review you said that you didn't hard nak this approach and would
like to hear opinion from virtualization guys. In this version we CCed KVM
mailing list, Paolo (VFIO/Qemu), Alex (VFIO), Samuel (Rust-VMM/Cloud
hypervisor), etc. Let's see how they feel about this approach.
Thanks
Kevin
next prev parent reply other threads:[~2020-07-21 23:55 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:02 [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver Dave Jiang
2020-07-21 16:02 ` [PATCH RFC v2 01/18] platform-msi: Introduce platform_msi_ops Dave Jiang
2020-07-21 16:02 ` [PATCH RFC v2 02/18] irq/dev-msi: Add support for a new DEV_MSI irq domain Dave Jiang
2020-07-21 16:13 ` Jason Gunthorpe
2020-07-22 16:50 ` Dey, Megha
2020-07-22 18:52 ` Marc Zyngier
2020-07-22 19:59 ` Jason Gunthorpe
2020-07-23 8:51 ` Marc Zyngier
2020-07-24 0:16 ` Jason Gunthorpe
2020-07-24 0:36 ` Thomas Gleixner
2020-08-05 19:18 ` Dey, Megha
2020-08-05 22:15 ` Jason Gunthorpe
2020-08-05 22:36 ` Dey, Megha
2020-08-05 22:53 ` Jason Gunthorpe
2020-08-06 0:13 ` Dey, Megha
2020-08-06 0:19 ` Jason Gunthorpe
2020-08-06 0:32 ` Dey, Megha
2020-08-06 0:46 ` Jason Gunthorpe
2020-08-06 17:10 ` Thomas Gleixner
2020-08-06 17:58 ` Dey, Megha
2020-08-06 20:21 ` Thomas Gleixner
2020-08-06 22:27 ` Dey, Megha
2020-08-07 8:48 ` Thomas Gleixner
2020-08-07 12:06 ` Jason Gunthorpe
2020-08-07 12:38 ` gregkh
2020-08-07 13:34 ` Jason Gunthorpe
2020-08-07 16:47 ` Thomas Gleixner
2020-08-07 17:54 ` Dey, Megha
2020-08-07 18:39 ` Jason Gunthorpe
2020-08-07 20:31 ` Dey, Megha
2020-08-08 19:47 ` Thomas Gleixner
2020-08-10 21:46 ` Thomas Gleixner
2020-08-11 9:53 ` Thomas Gleixner
2020-08-11 18:46 ` Dey, Megha
2020-08-11 21:25 ` Thomas Gleixner
2020-08-11 18:39 ` Dey, Megha
2020-08-11 22:39 ` Thomas Gleixner
2020-08-07 15:22 ` Thomas Gleixner
2020-08-05 18:55 ` Dey, Megha
2020-07-21 16:02 ` [PATCH RFC v2 03/18] irq/dev-msi: Create IR-DEV-MSI " Dave Jiang
2020-07-21 16:21 ` Jason Gunthorpe
2020-07-22 17:03 ` Dey, Megha
2020-07-22 17:33 ` Jason Gunthorpe
2020-07-22 20:44 ` Thomas Gleixner
2020-08-05 19:02 ` Dey, Megha
2020-07-21 16:02 ` [PATCH RFC v2 04/18] irq/dev-msi: Introduce APIs to allocate/free dev-msi interrupts Dave Jiang
2020-07-21 16:25 ` Jason Gunthorpe
2020-07-22 17:05 ` Dey, Megha
2020-07-22 17:35 ` Jason Gunthorpe
2020-08-05 20:19 ` Dey, Megha
2020-07-21 16:02 ` [PATCH RFC v2 05/18] dmaengine: idxd: add support for readonly config devices Dave Jiang
2020-07-21 16:02 ` [PATCH RFC v2 06/18] dmaengine: idxd: add interrupt handle request support Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 07/18] dmaengine: idxd: add DEV-MSI support in base driver Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 08/18] dmaengine: idxd: add device support functions in prep for mdev Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 09/18] dmaengine: idxd: add basic mdev registration and helper functions Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 10/18] dmaengine: idxd: add emulation rw routines Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 11/18] dmaengine: idxd: prep for virtual device commands Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 12/18] dmaengine: idxd: virtual device commands emulation Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 13/18] dmaengine: idxd: ims setup for the vdcm Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 14/18] dmaengine: idxd: add mdev type as a new wq type Dave Jiang
2020-07-21 16:03 ` [PATCH RFC v2 15/18] dmaengine: idxd: add dedicated wq mdev type Dave Jiang
2020-07-21 16:04 ` [PATCH RFC v2 16/18] dmaengine: idxd: add new wq state for mdev Dave Jiang
2020-07-21 16:04 ` [PATCH RFC v2 17/18] dmaengine: idxd: add error notification from host driver to mediated device Dave Jiang
2020-07-21 16:04 ` [PATCH RFC v2 18/18] dmaengine: idxd: add ABI documentation for mediated device support Dave Jiang
2020-07-21 16:28 ` [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver Greg KH
2020-07-21 17:17 ` Dave Jiang
2020-07-21 21:35 ` Dan Williams
2020-07-21 16:45 ` Jason Gunthorpe
2020-07-21 18:00 ` Dave Jiang
2020-07-22 17:31 ` Dey, Megha
2020-07-22 18:16 ` Jason Gunthorpe
2020-07-21 23:54 ` Tian, Kevin [this message]
2020-07-24 0:19 ` Jason Gunthorpe
2020-08-06 1:22 ` Alex Williamson
2020-08-07 12:19 ` Jason Gunthorpe
2020-08-10 7:32 ` Tian, Kevin
2020-08-11 17:00 ` Alex Williamson
2020-08-12 1:58 ` Tian, Kevin
2020-08-12 2:36 ` Alex Williamson
2020-08-12 3:35 ` Tian, Kevin
2020-08-12 3:28 ` Jason Wang
2020-08-12 4:05 ` Tian, Kevin
2020-08-13 4:33 ` Jason Wang
2020-08-13 5:26 ` Tian, Kevin
2020-08-13 6:01 ` Jason Wang
2020-08-14 13:23 ` Jason Gunthorpe
2020-08-17 2:24 ` Tian, Kevin
2020-08-14 13:35 ` Jason Gunthorpe
2020-08-17 2:12 ` Tian, Kevin
2020-08-18 0:43 ` Jason Gunthorpe
2020-08-18 1:09 ` Tian, Kevin
2020-08-18 11:50 ` Jason Gunthorpe
2020-08-18 16:27 ` Paolo Bonzini
2020-08-18 16:49 ` Jason Gunthorpe
2020-08-18 17:05 ` Paolo Bonzini
2020-08-18 17:18 ` Jason Gunthorpe
2020-08-19 7:29 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1638103EC73DD9C025F144C98C780@CY4PR11MB1638.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@mellanox.com \
--cc=jing.lin@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=megha.dey@intel.com \
--cc=mona.hossain@intel.com \
--cc=netanelg@mellanox.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=rafael@kernel.org \
--cc=samuel.ortiz@intel.com \
--cc=sanjay.k.kumar@intel.com \
--cc=shahafs@mellanox.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=x86@kernel.org \
--cc=yan.y.zhao@linux.intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).