[PATCH] dmaengine: idxd: fix opcap sysfs attribute output

[PATCH] dmaengine: idxd: fix opcap sysfs attribute output

[Dave Jiang]

The operation capability register is 256bits. The current output only
prints out the first 64bits. Fix to output the entire 256bits. The current
code omits operation caps from IAX devices.

Fixes: c52ca478233c ("dmaengine: idxd: add configuration component of driver")
Reported-by: Lucas Van <lucas.van@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/idxd/sysfs.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
index e018d2339ccd..9cc7ad939307 100644
--- a/drivers/dma/idxd/sysfs.c
+++ b/drivers/dma/idxd/sysfs.c
@@ -1427,8 +1427,14 @@ static ssize_t op_cap_show(struct device *dev,
 {
 	struct idxd_device *idxd =
 		container_of(dev, struct idxd_device, conf_dev);
+	int i, rc = 0;
+
+	for (i = 0; i < 4; i++)
+		rc += sysfs_emit_at(buf, rc, "%#llx ", idxd->hw.opcap.bits[i]);
 
-	return sprintf(buf, "%#llx\n", idxd->hw.opcap.bits[0]);
+	rc--;
+	rc += sysfs_emit_at(buf, rc, "\n");
+	return rc;
 }
 static DEVICE_ATTR_RO(op_cap);
 

Re: [PATCH] dmaengine: idxd: fix opcap sysfs attribute output

[Vinod Koul]

On 22-03-21, 16:37, Dave Jiang wrote:
> The operation capability register is 256bits. The current output only
> prints out the first 64bits. Fix to output the entire 256bits. The current
> code omits operation caps from IAX devices.

Applied, thanks

-- 
~Vinod