* [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
@ 2021-05-31 6:36 Zou Wei
2021-05-31 7:23 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zou Wei @ 2021-05-31 6:36 UTC (permalink / raw)
To: vkoul, yoshihiro.shimoda.uh, geert+renesas, wsa+renesas,
laurent.pinchart, robin.murphy
Cc: dmaengine, linux-kernel, Zou Wei
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/dma/sh/rcar-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index d530c1b..6885b3d 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)
/* Enable runtime PM and initialize the device. */
pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0) {
dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
return ret;
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
2021-05-31 6:36 [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Zou Wei
@ 2021-05-31 7:23 ` Geert Uytterhoeven
2021-05-31 7:33 ` Laurent Pinchart
2021-06-03 11:07 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-05-31 7:23 UTC (permalink / raw)
To: Zou Wei
Cc: Vinod, Yoshihiro Shimoda, Wolfram Sang, Laurent Pinchart,
Robin Murphy, dmaengine, Linux Kernel Mailing List
On Mon, May 31, 2021 at 8:17 AM Zou Wei <zou_wei@huawei.com> wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
2021-05-31 6:36 [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Zou Wei
2021-05-31 7:23 ` Geert Uytterhoeven
@ 2021-05-31 7:33 ` Laurent Pinchart
2021-06-03 11:07 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2021-05-31 7:33 UTC (permalink / raw)
To: Zou Wei
Cc: vkoul, yoshihiro.shimoda.uh, geert+renesas, wsa+renesas,
robin.murphy, dmaengine, linux-kernel
Hi Zou,
Thank you for the patch.
On Mon, May 31, 2021 at 02:36:03PM +0800, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/dma/sh/rcar-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index d530c1b..6885b3d 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1913,7 +1913,7 @@ static int rcar_dmac_probe(struct platform_device *pdev)
>
> /* Enable runtime PM and initialize the device. */
> pm_runtime_enable(&pdev->dev);
> - ret = pm_runtime_get_sync(&pdev->dev);
> + ret = pm_runtime_resume_and_get(&pdev->dev);
> if (ret < 0) {
> dev_err(&pdev->dev, "runtime PM get sync failed (%d)\n", ret);
> return ret;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe()
2021-05-31 6:36 [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Zou Wei
2021-05-31 7:23 ` Geert Uytterhoeven
2021-05-31 7:33 ` Laurent Pinchart
@ 2021-06-03 11:07 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-06-03 11:07 UTC (permalink / raw)
To: Zou Wei
Cc: yoshihiro.shimoda.uh, geert+renesas, wsa+renesas,
laurent.pinchart, robin.murphy, dmaengine, linux-kernel
On 31-05-21, 14:36, Zou Wei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03 11:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 6:36 [PATCH -next] dmaengine: rcar-dmac: Fix PM reference leak in rcar_dmac_probe() Zou Wei
2021-05-31 7:23 ` Geert Uytterhoeven
2021-05-31 7:33 ` Laurent Pinchart
2021-06-03 11:07 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).