* [PATCH] dmaengine: fsl-dpaa2-qdma: Drop comma after SoC match table sentinel
@ 2022-03-03 12:47 Geert Uytterhoeven
2022-03-11 10:17 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-03-03 12:47 UTC (permalink / raw)
To: Vinod Koul, Shawn Guo, Li Yang
Cc: dmaengine, linux-arm-kernel, Geert Uytterhoeven
It does not make sense to have a comma after a sentinel, as any new
elements must be added before the sentinel.
Add a comment to clarify the purpose of the empty element.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h
index 7d571849c569cb32..03e2f4e0baca83d2 100644
--- a/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h
+++ b/drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.h
@@ -139,7 +139,7 @@ struct dpaa2_qdma_priv_per_prio {
static struct soc_device_attribute soc_fixup_tuning[] = {
{ .family = "QorIQ LX2160A"},
- { },
+ { /* sentinel */ }
};
/* FD pool size: one FD + 3 Frame list + 2 source/destination descriptor */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: fsl-dpaa2-qdma: Drop comma after SoC match table sentinel
2022-03-03 12:47 [PATCH] dmaengine: fsl-dpaa2-qdma: Drop comma after SoC match table sentinel Geert Uytterhoeven
@ 2022-03-11 10:17 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2022-03-11 10:17 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Shawn Guo, Li Yang, dmaengine, linux-arm-kernel
On 03-03-22, 13:47, Geert Uytterhoeven wrote:
> It does not make sense to have a comma after a sentinel, as any new
> elements must be added before the sentinel.
>
> Add a comment to clarify the purpose of the empty element.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-11 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 12:47 [PATCH] dmaengine: fsl-dpaa2-qdma: Drop comma after SoC match table sentinel Geert Uytterhoeven
2022-03-11 10:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).